Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastCGI review #6693

Closed
sbordet opened this issue Sep 2, 2021 · 0 comments · Fixed by #6694
Closed

FastCGI review #6693

sbordet opened this issue Sep 2, 2021 · 0 comments · Fixed by #6694
Assignees

Comments

@sbordet
Copy link
Contributor

sbordet commented Sep 2, 2021

Target Jetty version(s)
10.0.x

Enhancement Description
In Jetty 10, FastCGI has been minimally updated to drop the support for multiplexing (#2095), as the protocol itself does not support it right, and in practice this feature is never used.

However, a lot of code that was handling multiplexing was left there.
The client is more inefficient and the server produces race conditions such as those reported in e.g. #6217.

sbordet added a commit that referenced this issue Sep 2, 2021
- Removed code supporting multiplex in the client.
- Removed code supporting multiplex in the server.
- Reworked the server-side processing of a request, now more similar to HTTP/1.1.
- Improved javadocs.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet linked a pull request Sep 2, 2021 that will close this issue
@sbordet sbordet self-assigned this Sep 2, 2021
sbordet added a commit that referenced this issue Sep 2, 2021
Fixed javadocs.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Sep 3, 2021
Updates after review.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Sep 6, 2021
Updates after review.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Sep 7, 2021
* Fixes #6693 - FastCGI review

- Removed code supporting multiplex in the client.
- Removed code supporting multiplex in the server.
- Reworked the server-side processing of a request, now more similar to HTTP/1.1.
- Improved javadocs.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant