Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServerUpgradeRequest.getCookies() can throws NullPointerException #6654

Closed
EricBlanquer opened this issue Aug 23, 2021 · 2 comments · Fixed by #6655
Closed

ServerUpgradeRequest.getCookies() can throws NullPointerException #6654

EricBlanquer opened this issue Aug 23, 2021 · 2 comments · Fixed by #6655
Assignees
@joakime
Labels
Bug For general bugs on Jetty side
Projects
Jetty 10.0.7/11.0.7 FROZEN

Comments

@EricBlanquer
Copy link

https://github.com/eclipse/jetty.project/blob/b2c420a124392b3e79a6abf263ec00f51e387409/jetty-websocket/websocket-core-server/src/main/java/org/eclipse/jetty/websocket/core/server/ServerUpgradeRequest.java#L93

Hi,
request.getCookies() can be null and this code can throws a NullPointerException
@EricBlanquer EricBlanquer changed the title ServerUpgradeRequest can throws NullPointerException ServerUpgradeRequest.getCookies() can throws NullPointerException Aug 23, 2021
@joakime joakime added the Bug For general bugs on Jetty side label Aug 23, 2021
@joakime joakime added this to To do in Jetty 10.0.7/11.0.7 FROZEN via automation Aug 23, 2021
@joakime
Copy link
Contributor

joakime commented Aug 23, 2021

Not a bug in Jetty 9.4.x

https://github.com/eclipse/jetty.project/blob/jetty-9.4.43.v20210629/jetty-websocket/websocket-servlet/src/main/java/org/eclipse/jetty/websocket/servlet/ServletUpgradeRequest.java#L99-L117

https://github.com/eclipse/jetty.project/blob/526006ecfa3af7f1a27ef3a288e2bef7ea9dd7e8/jetty-websocket/websocket-servlet/src/main/java/org/eclipse/jetty/websocket/servlet/ServletUpgradeRequest.java#L99-L117

This exists as a bug in Jetty 10.x and Jetty 11.x

joakime added a commit that referenced this issue Aug 23, 2021
@joakime
Issue #6654 - Fix NPEs from bad Servlet API use
401f195 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime linked a pull request Aug 23, 2021 that will close this issue
Issue #6654 - Fix NPEs from bad Servlet API use #6655
Merged
@joakime
Copy link
Contributor

joakime commented Aug 23, 2021

Opened PR #6655

@joakime joakime assigned joakime and unassigned lachlan-roberts Aug 23, 2021
@joakime joakime moved this from To do to Review in progress in Jetty 10.0.7/11.0.7 FROZEN Aug 23, 2021
joakime added a commit that referenced this issue Aug 23, 2021
@joakime
Issue #6654 - Fix NPEs from bad Servlet API use
32e6698 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Aug 24, 2021
@joakime
Issue #6654 - Fix NPEs from bad Servlet API use
a82b45c 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Jetty 10.0.7/11.0.7 FROZEN automation moved this from Review in progress to Done Aug 25, 2021
joakime added a commit that referenced this issue Aug 25, 2021
@joakime
Merge pull request #6655 from eclipse/jetty-10.0.x-6654-websocket-upg…
3badb86 
…rade-npe-request-cookies

Issue #6654 - Fix NPEs from bad Servlet API use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 10.0.7/11.0.7 FROZEN
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #6654 - Fix NPEs from bad Servlet API use jetty/jetty.project
3 participants
@joakime @EricBlanquer @lachlan-roberts