Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flakey test ConnectionPoolTest.testConnectionMaxUsage #6455

Closed
janbartel opened this issue Jun 21, 2021 · 1 comment · Fixed by #6463 or #6475
Closed

Flakey test ConnectionPoolTest.testConnectionMaxUsage #6455

janbartel opened this issue Jun 21, 2021 · 1 comment · Fixed by #6463 or #6475
Assignees
@lorban
Labels
Bug For general bugs on Jetty side Test
Projects
Jetty 9.4.44 FROZEN Jetty 10.0.7/11.0.7 FROZEN

Comments

@janbartel
Copy link
Contributor

jetty-10.0.x

Test fails sometimes, see eg
https://jenkins.webtide.net/blue/organizations/jenkins/jetty.project/detail/jetty-10-6442-Remove-IRC-reference/1/pipeline
@janbartel janbartel added Bug For general bugs on Jetty side Test labels Jun 21, 2021
@lorban lorban self-assigned this Jun 23, 2021
@lorban
Copy link
Contributor

lorban commented Jun 23, 2021

This test also fails sporadically on 9.4.x.

I've managed to reproduce it, it is basically due to some incompatibility between the duplex-maxDuration pool and the test's assertions.

The duplex-maxDuration pool is configured to make its connections expire after 10ms. If for some reason the delay between the 1st and the 2nd requests in testConnectionMaxUsage takes more than 10ms, then the existing connection that the test expects to be removed because it reached its max usage is actually replaced by a fresh one that did not reach the max usage limit, hence failing the assertion.

Forcing the MaxDuration mechanism to be disabled for that test should solve this problem for good.

lorban added a commit that referenced this issue Jun 23, 2021
@lorban
#6455 disable MaxDuration mechanism in testConnectionMaxUsage as it …
a04c9ae 
…clashes with the test's assertions

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban linked a pull request Jun 24, 2021 that will close this issue
disable MaxDuration mechanism in testConnectionMaxUsage #6463
Merged
@lorban lorban removed a link to a pull request Jun 24, 2021
disable MaxDuration mechanism in testConnectionMaxUsage #6463
Merged
@lorban lorban mentioned this issue Jun 24, 2021
Merged
@lorban lorban added this to To do in Jetty 9.4.44 FROZEN via automation Jun 24, 2021
@lorban lorban added this to To do in Jetty 10.0.7/11.0.7 FROZEN via automation Jun 24, 2021
lorban added a commit that referenced this issue Jun 28, 2021
@lorban
#6455 disable MaxDuration mechanism in testConnectionMaxUsage as it …
16d8b23 
…clashes with the test's assertions

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban linked a pull request Jun 28, 2021 that will close this issue
disable MaxDuration mechanism in testConnectionMaxUsage #6463
Merged
lorban added a commit that referenced this issue Jun 28, 2021
@lorban
#6455 disable MaxDuration mechanism in testConnectionMaxUsage as it …
b0d6828 
…clashes with the test's assertions

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban linked a pull request Jun 28, 2021 that will close this issue
disable MaxDuration mechanism in testConnectionMaxUsage #6475
Merged
Jetty 9.4.44 FROZEN automation moved this from To do to Done Jun 29, 2021
Jetty 10.0.7/11.0.7 FROZEN automation moved this from To do to Done Jun 29, 2021
lorban added a commit that referenced this issue Jun 29, 2021
@lorban
#6455 disable MaxDuration mechanism in testConnectionMaxUsage as it …
c753ca0 
…clashes with the test's assertions

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorban lorban

Labels
Bug For general bugs on Jetty side Test
Projects
No open projects
Jetty 10.0.7/11.0.7 FROZEN
Done
Jetty 9.4.44 FROZEN
Done
Milestone
No milestone
2 participants
@janbartel @lorban