Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review accidental xml config changes #6392

Closed
janbartel opened this issue Jun 10, 2021 · 1 comment · Fixed by #6348
Closed

Review accidental xml config changes #6392

janbartel opened this issue Jun 10, 2021 · 1 comment · Fixed by #6348
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@janbartel
Copy link
Contributor

jetty-10/jetty-11

This supersedes issue #6329. Analysing #6329 (jetty 10/11 does not stop on shutdown by default when running in the distro) revealed that commit 343cf73 had inadvertently changed a number of default values in jetty xml config files. We need to review the config changes, and where necessary revert/fix incorrect changes.

@janbartel janbartel added the Bug For general bugs on Jetty side label Jun 10, 2021
@janbartel janbartel self-assigned this Jun 10, 2021
@janbartel janbartel added this to To do in Jetty 10.0.5/11.0.5 FROZEN via automation Jun 10, 2021
@janbartel janbartel changed the title Revert accidental xml config changes Review accidental xml config changes Jun 10, 2021
@gregw gregw moved this from To do to Reviewer approved in Jetty 10.0.5/11.0.5 FROZEN Jun 10, 2021
@janbartel
Copy link
Contributor Author

The changes resulting from review are:

gcloud session store

  • removed defaults set in xml file in favour of using defaults set in code
  • added property to configure name of lastSaved field for session in gcloud (set to the code default)

hazelcast session store

  • removed defaults set in xml file as they are the same as the code defaults

jdbc session store

  • removed defaults set in xml in favour of using defaults set in code

http2c

  • changed property values in http2c.mod file to be the same as the code defaults
  • removed default for maxSettingsKeys in xml file (ie use code default)

unixsocket-http2c

  • changed property values in .mod file to be the same as the code defaults

server

  • changed jetty.httpConfig.uriCompliance in server.mod from a non-existent value to a proper value
  • restored setStopAtShutdown default to true for jetty.xml
  • restored sendDateHeader default to false for jetty.xml

rewrite

  • restored default value of originalPathAttribute in jetty-rewrite.xml

rewrite-customizer

  • restored default value of originalPathAttribute in jetty-rewrite-customizer.xml

gzip

  • removed non-existent setters from jetty-gzip.xml:
<Set name="checkGzExists" property="jetty.gzip.checkGzExists"/>
<Set name="compressionLevel" property="jetty.gzip.compressionLevel"/>
  • removed deprecated setters from 'jetty-gzip.xml:
<Set name="inflaterPoolCapacity" property="jetty.gzip.inflaterPoolCapacity"/>		
<Set name="deflaterPoolCapacity" property="jetty.gzip.deflaterPoolCapacity"/>
  • added properties to correctly configure the InflaterPool and DeflaterPool

threadlimit

  • restored default of true for ThreadLimitHandler.enabled

Jetty 10.0.5/11.0.5 FROZEN automation moved this from Reviewer approved to Done Jun 10, 2021
janbartel added a commit that referenced this issue Jun 10, 2021
* Issue #6392 Review accidental xml config changes

Signed-off-by: Jan Bartel <janb@webtide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant