New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use RetainableByteBuffer
in HttpConnection
#6322
Comments
@lorban Simone suggested that we do this. I had a quick look at the input side at least looks achievable, so I thought I'd punt to you with your HttpInput experience. I think it can be done entirely in |
@gregw I don't think the output side is involved at all, as On the output side, all implementations currently rely on pooled "naked" |
Add a Log2 bucket size imple for ArrayRetainableByteBufferPool Signed-off-by: Greg Wilkins <gregw@webtide.com>
Add a Log2 bucket size impl for ArrayRetainableByteBufferPool Signed-off-by: Greg Wilkins <gregw@webtide.com>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Dumpable Signed-off-by: Greg Wilkins <gregw@webtide.com>
Sampled Pool Signed-off-by: Greg Wilkins <gregw@webtide.com>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Add a exponential bucket size impl to test ArrayRetainableByteBufferPool extensibility Signed-off-by: Greg Wilkins <gregw@webtide.com>
Once the next release is out, we need to ask for a few ByteBufferPool dumps from real deployments so we can plot histograms of buffer sizes in the pool. |
The
org.eclipse.jetty.server.HttpConnection
class should useorg.eclipse.jetty.io.RetainableByteBuffer
rather than it's own reference counting of buffers. This will eventually allow a more efficient buffer pool abstraction to be used that providesRetainableByteBuffers
directly.The text was updated successfully, but these errors were encountered: