Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat empty path segments are ambiguous. #6302

Closed
lachlan-roberts opened this issue May 20, 2021 · 3 comments · Fixed by #6304
Closed

Treat empty path segments are ambiguous. #6302

lachlan-roberts opened this issue May 20, 2021 · 3 comments · Fixed by #6304

Comments

@lachlan-roberts
Copy link
Contributor

Description

Empty path segments // should be treated as ambiguous by HttpUri.
@lachlan-roberts lachlan-roberts changed the title Treat empty segments are ambiguous. Treat empty path segments are ambiguous. May 20, 2021
lachlan-roberts added a commit that referenced this issue May 20, 2021
@lachlan-roberts
Issue #6302 - Treat empty path segments are ambiguous.
36332ab 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@sbordet sbordet linked a pull request Jun 4, 2021 that will close this issue
Issue #6302 - Treat empty path segments as ambiguous. #6304
Merged
@lachlan-roberts
Copy link
Contributor Author

@sbordet Do we want this change brought back to 9.4.x as well?

If so it should not be "linked" to PR #6304 which will close this when it is merged.
And this should also be assigned the to 9.4.43 project so it is not forgotten.

sbordet pushed a commit that referenced this issue Jun 10, 2021
@lachlan-roberts @gregw
Issue #6302 - Treat empty path segments as ambiguous. (#6304)
b4d7e51 
Issue #6302 - Treat empty path segments are ambiguous.

* Fix false empty segments being reported.
* Add HttpUriTests for the empty segment as ambiguous

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Co-authored-by: Greg Wilkins <gregw@webtide.com>
@sbordet
Copy link
Contributor

sbordet commented Jun 10, 2021

@sbordet Do we want this change brought back to 9.4.x as well?

I think so, but I'll let @gregw decide.

We do have "ambiguous" handling in 9.4.x, just different, right?

@gregw
Copy link
Contributor

gregw commented Jun 11, 2021

hmmm it is kind of a new feature.... not entirely sure we need it in 9. Historically we have broken more things than we fixed when we have done such changes.
So I'm inclined to at least see how the feature plays out in 10 before moving it to 9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #6302 - Treat empty path segments as ambiguous. jetty/jetty.project
3 participants
@gregw @sbordet @lachlan-roberts