Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy ServletHolder class/instance properly during startWebapp #6280

Closed
gregw opened this issue May 16, 2021 · 0 comments · Fixed by #6214
Closed

Copy ServletHolder class/instance properly during startWebapp #6280

gregw opened this issue May 16, 2021 · 0 comments · Fixed by #6214
Projects
Jetty 9.4.41

Comments

@gregw
Copy link
Contributor

gregw commented May 16, 2021

When a forced-file (aka jsp-file) servlet holder is found, the held class is copied over from the servlet named "JSP". However, only the class name is copied, so if there is a class instance from a different classloader, the resulting servlet holder will fail. Any class instance also needs to be copied.
@gregw gregw mentioned this issue May 16, 2021
Merged
@gregw gregw linked a pull request May 16, 2021 that will close this issue
Copy ServletHolder class/instance properly during startWebapp #6214
Merged
@gregw gregw mentioned this issue May 16, 2021
Merged
gregw added a commit that referenced this issue May 16, 2021
@gregw @joakime
Jetty 10.0.x servletholder copy #6280 (#6281)
804630d 
Copy ServletHolder class/instance properly during startWebapp (#6214)
ServletHolder.copyClassServlet() method added to correctly copy held class.
Cherry picked from 9.4

Signed-off-by: Greg Wilkins <gregw@webtide.com>
Co-authored-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@gregw gregw closed this as completed May 17, 2021
@gregw gregw added this to To do in Jetty 9.4.41 via automation May 17, 2021
@gregw gregw moved this from To do to Done in Jetty 9.4.41 May 17, 2021
@olamy olamy mentioned this issue May 21, 2021
Merged
olamy added a commit that referenced this issue May 21, 2021
@olamy
add missing issue #6280
741ebb9 
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
olamy added a commit that referenced this issue May 21, 2021
@olamy
add jetty-9.4.41.v20210516 infos in VERSION.TXT (#6300)
90d90cb 
* add jetty-9.4.41.v20210516 infos in VERSION.TXT

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>

* add missing issue #6280

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Jetty 9.4.41
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Copy ServletHolder class/instance properly during startWebapp jetty/jetty.project
1 participant
@gregw