Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make jetty-jspc-maven-plugin @threadSafe #6224

Closed
gbo80 opened this issue Apr 29, 2021 · 3 comments
Closed

make jetty-jspc-maven-plugin @threadSafe #6224

gbo80 opened this issue Apr 29, 2021 · 3 comments
Assignees
Milestone

Comments

@gbo80
Copy link

gbo80 commented Apr 29, 2021

Jetty version
9.x, 10.x, 11.x

Description
Running the jetty-jspc-maven-plugin in a maven build that uses multiple threads (e.g. "mvn -T1C ...") works (so far I found no problems), but I get a warning that the plugin is not @threadSafe.

[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but project      *
[WARNING] * contains the following plugin(s) that have goals not marked   *
[WARNING] * as @threadSafe to support parallel building.                  *
[WARNING] * While this /may/ work fine, please look for plugin updates    *
[WARNING] * and/or request plugins be made thread-safe.                   *
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against maven-core                              *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked @threadSafe in my-web:
[WARNING] org.eclipse.jetty:jetty-jspc-maven-plugin:9.4.40.v20210413
[WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
[WARNING] *****************************************************************

Question
Do we have to expect problems when running a multi-module project that contains multiple web projects with multiple threads?
We use the JSP precompiler in the maven build only for detecting compilation problems while building.
We do not use the precompiled JSPs in production.

Change request
Please make the plugin @threadSafe.

Thanks
Günther

@janbartel
Copy link
Contributor

@gbo80 I don't anticipate that you will have any threading issues with the jetty-jspc-maven-plugin, but we'll look at adding the appropriate annotation to the plugin.

@olamy olamy self-assigned this Apr 30, 2021
@olamy olamy modified the milestones: 10.0.x, 9.4.x Apr 30, 2021
olamy added a commit that referenced this issue May 2, 2021
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
@olamy olamy added this to To do in Jetty 10.0.3/11.0.3 via automation May 2, 2021
@gbo80
Copy link
Author

gbo80 commented May 3, 2021

Thank you very much!

olamy added a commit that referenced this issue May 6, 2021
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
olamy added a commit that referenced this issue May 7, 2021
* Issue #6224 make jspc mojo maven threadsafe

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>

* restore previous behaviour

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
@olamy
Copy link
Member

olamy commented May 7, 2021

pr merged 04e5c4e

@olamy olamy closed this as completed May 7, 2021
Jetty 10.0.3/11.0.3 automation moved this from To do to Done May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants