Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of unconsumed content #6168

Closed
sbordet opened this issue Apr 13, 2021 · 2 comments · Fixed by #6163
Closed

Improve handling of unconsumed content #6168

sbordet opened this issue Apr 13, 2021 · 2 comments · Fixed by #6163
Projects
Jetty 9.4.40

Comments

@sbordet
Copy link
Contributor

sbordet commented Apr 13, 2021

Jetty version
9.4.x

Description
The case of unconsumed content, and HttpInput.Interceptor throwing an exception, should be handled better.
In particular, make sure that exceptions thrown by the interceptor are correctly handled.
@sbordet
Copy link
Contributor Author

sbordet commented Apr 13, 2021

See also #6167.

sbordet added a commit that referenced this issue Apr 13, 2021
@sbordet
Fixes #6168 - Improve handling of unconsumed content
fe359ac 
Added or expanded the scope of catch blocks to properly handle exceptions thrown by `HttpInput.Interceptor`.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@gregw
Copy link
Contributor

gregw commented Apr 13, 2021

Also, whilst doing a consumeAll, the interceptors should not be called as that can waste CPU and memory.

@sbordet sbordet linked a pull request Apr 14, 2021 that will close this issue
Jetty 9.4.x unconsumed content2 #6163
Merged
@sbordet sbordet added this to To do in Jetty 9.4.40 via automation Apr 14, 2021
@sbordet sbordet moved this from To do to Done in Jetty 9.4.40 Apr 14, 2021
@joakime joakime closed this as completed Apr 16, 2021
@sbordet sbordet mentioned this issue May 5, 2021
Closed
@lorban lorban mentioned this issue Dec 13, 2021
Closed
@joakime joakime mentioned this issue Mar 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Jetty 9.4.40
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jetty 9.4.x unconsumed content2 jetty/jetty.project
4 participants
@gregw @joakime @sbordet and others