Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty start.jar always reports jetty.tag.version as master #6148

Closed
joakime opened this issue Apr 8, 2021 · 1 comment · Fixed by #6149
Closed

Jetty start.jar always reports jetty.tag.version as master #6148

joakime opened this issue Apr 8, 2021 · 1 comment · Fixed by #6149
Assignees
@joakime
Labels
Bug For general bugs on Jetty side
Projects
Jetty 9.4.40

Comments

@joakime
Copy link
Contributor

joakime commented Apr 8, 2021

Jetty version
9.4.x+

Java version
All versions

OS type/version
All.

Description
When the start.jar --list-config is used, the following output is produced ...

--(snip)--
Jetty Environment:
-----------------
 jetty.version = 9.4.39.v20210325
 jetty.tag.version = master
--(snip)--

The jetty.tag.version always reports as master.
This should either be the tag name, or the build-number (git sha).
@joakime joakime added the Bug For general bugs on Jetty side label Apr 8, 2021
@joakime joakime self-assigned this Apr 8, 2021
@joakime joakime added this to To do in Jetty 9.4.40 via automation Apr 8, 2021
joakime added a commit that referenced this issue Apr 8, 2021
@joakime
Issue #6148 - update jetty.tag.version behavior
8715600 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime moved this from To do to Review Pending in Jetty 9.4.40 Apr 8, 2021
@joakime joakime linked a pull request Apr 8, 2021 that will close this issue
Issue #6148 - update jetty.tag.version behavior #6149
Merged
joakime added a commit that referenced this issue Apr 9, 2021
@joakime
Issue #6148 - introduce jetty.build to show git sha for build
19a1b0c 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Apr 12, 2021
@joakime
Merge pull request #6149 from eclipse/jetty-9.4.x-start-tag-name
23c45c0 
Issue #6148 - update jetty.tag.version behavior
@joakime
Copy link
Contributor Author

joakime commented Apr 12, 2021

Merged PR #6149

@joakime joakime closed this as completed Apr 12, 2021
Jetty 9.4.40 automation moved this from Review Pending to Done Apr 12, 2021
@joakime joakime mentioned this issue May 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 9.4.40
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #6148 - update jetty.tag.version behavior jetty/jetty.project
2 participants
@joakime and others