Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup TypeUtil and ModuleLocation to allow jetty-client/hybrid to work on Android #6052

Closed
joakime opened this issue Mar 10, 2021 · 2 comments · Fixed by #6053
Closed

Cleanup TypeUtil and ModuleLocation to allow jetty-client/hybrid to work on Android #6052

joakime opened this issue Mar 10, 2021 · 2 comments · Fixed by #6053
Labels
Enhancement Sponsored This issue affects a user with a commercial support agreement Stale For auto-closed stale issues and pull requests
Projects
Jetty 10.0.2/11.0.2 Jetty 9.4.39

Comments

@joakime
Copy link
Contributor

joakime commented Mar 10, 2021

Jetty version
9.4.x

Java version
Android

OS type/version
Android

Description
When attempting to use jetty-client-<ver>-hybrid.jar on Android.
The TypeUtil has an optional dependency on ModuleLocation which uses MethodHandle.invoke and MethodHandle.invokeExact, both of which are not supported by Android (yet)

Attempt to make the use of ModuleLocation in a more optional way.
joakime added a commit that referenced this issue Mar 10, 2021
@joakime
Issue #6052 - make ModuleLocation optional on Android
d7982f8 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime linked a pull request Mar 10, 2021 that will close this issue
Issue #6052 - make ModuleLocation optional on Android #6053
Merged
joakime added a commit that referenced this issue Mar 15, 2021
@joakime
Issue #6052 - Removing MethodHandle from TypeUtil static initializer
a3a1478 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Mar 15, 2021
@joakime
Issue #6052 - Applying changes from review
9e29832 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Mar 15, 2021
@joakime
Merge pull request #6053 from eclipse/jetty-9.4.x-client-hybrid-smaller
f92394e 
Issue #6052 - make ModuleLocation optional on Android
@gregw gregw added this to To do in Jetty 10.0.2/11.0.2 via automation Mar 25, 2021
@gregw gregw moved this from To do to Done in Jetty 10.0.2/11.0.2 Mar 25, 2021
@gregw gregw added this to Done in Jetty 9.4.39 Mar 25, 2021
@joakime joakime added Enhancement Sponsored This issue affects a user with a commercial support agreement labels Apr 2, 2021
@joakime joakime mentioned this issue Oct 8, 2021
Closed
@github-actions
Copy link

github-actions bot commented Apr 3, 2022

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Apr 3, 2022
@joakime
Copy link
Contributor Author

joakime commented Apr 3, 2022

Merged PR #6053

@joakime joakime closed this as completed Apr 3, 2022
@amatsehor-atd amatsehor-atd mentioned this issue Apr 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Sponsored This issue affects a user with a commercial support agreement Stale For auto-closed stale issues and pull requests
Projects
No open projects
Jetty 10.0.2/11.0.2
Done
Jetty 9.4.39
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #6052 - make ModuleLocation optional on Android jetty/jetty.project
1 participant
@joakime