Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement UnixSocket support based on Java 16 #6043

Closed
sbordet opened this issue Mar 8, 2021 · 0 comments · Fixed by #6522
Closed

Reimplement UnixSocket support based on Java 16 #6043

sbordet opened this issue Mar 8, 2021 · 0 comments · Fixed by #6522

Comments

@sbordet
Copy link
Contributor

sbordet commented Mar 8, 2021

Jetty version
10.0.x

Description
Java 16 provides an implementation of Unix Sockets (JEP 380).

We should provide an implementation based on that rather than the more unstable JNR.

sbordet added a commit that referenced this issue Jul 16, 2021
* Introduced new module "jetty-server-unixdomain".
It uses reflection to access the Java 16 Unix-Domain classes to keep compatibility with the other modules and the build.
* Added Jetty module with only HTTP/1.1 support for now (requires review of the modules to reuse them with various connectors).
* Updated documentation to mention UnixDomainServerConnector.
* Updated client libraries to support Unix-Domain.
* Updated PROXY protocol implementation to support Unix-Domain.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet added this to To do in Jetty 10.0.7/11.0.7 FROZEN via automation Aug 4, 2021
sbordet added a commit that referenced this issue Aug 4, 2021
Replaced unix.socket.tmp with better named jetty.unixdomain.dir property.
Defaulted jetty.unixdomain.dir property to system property user.home under Windows.
Simplified code that runs Unix-Domain tests.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Aug 4, 2021
Fixed Unix-Domain profile for Windows.
Fixed test to make it work on Windows.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Jetty 10.0.7/11.0.7 FROZEN automation moved this from To do to Done Aug 5, 2021
sbordet added a commit that referenced this issue Aug 5, 2021
Fixes #6043 - Reimplement UnixSocket support based on Java 16.

* Introduced new module "jetty-server-unixdomain".
It uses reflection to access the Java 16 Unix-Domain classes to keep compatibility with the other modules and the build.
* Added Jetty module with only HTTP/1.1 support for now (requires review of the modules to reuse them with various connectors).
* Updated documentation to mention UnixDomainServerConnector.
* Updated client libraries to support Unix-Domain.
* Updated PROXY protocol implementation to support Unix-Domain.
* Replaced unix.socket.tmp with better named jetty.unixdomain.dir property.
Defaulted jetty.unixdomain.dir property to system property user.home under Windows.
Simplified code that runs Unix-Domain tests.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant