Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable gzip Etag extension #5979

Closed
gregw opened this issue Feb 17, 2021 · 1 comment · Fixed by #5980, #6539, #6945, #7960 or #8066
Closed

Configurable gzip Etag extension #5979

gregw opened this issue Feb 17, 2021 · 1 comment · Fixed by #5980, #6539, #6945, #7960 or #8066
Assignees
@gregw
Labels
Enhancement Sponsored This issue affects a user with a commercial support agreement
Projects
Jetty 9.4.37

Comments

@gregw
Copy link
Contributor

gregw commented Feb 17, 2021

Jetty version
9.4.x

Description

Allow the gzip extension to etag to be configurable.
@gregw gregw added Enhancement Sponsored This issue affects a user with a commercial support agreement labels Feb 17, 2021
@gregw gregw self-assigned this Feb 17, 2021
@gregw gregw added this to To do in Jetty 9.4.37 via automation Feb 17, 2021
gregw added a commit that referenced this issue Feb 17, 2021
@gregw
Fix #5979 by allowing a configurable etag separator.
fcbd0f7 
Fix #5979 by allowing a configurable etag separator
@gregw gregw mentioned this issue Feb 17, 2021
Merged
@gregw gregw linked a pull request Feb 17, 2021 that will close this issue
Fix #5979 by allowing a configurable etag separator. #5980
Merged
gregw added a commit that referenced this issue Feb 17, 2021
@gregw
Fix #5979 by allowing a configurable etag separator. (#5980)
a8b4927 
* Fix #5979 by allowing a configurable etag separator.

Fix #5979 by allowing a configurable etag separator

* updates from review

* Updates from review

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw closed this as completed Feb 17, 2021
Jetty 9.4.37 automation moved this from To do to Done Feb 17, 2021
olamy pushed a commit that referenced this issue Feb 17, 2021
@gregw @olamy
Fix #5979 by allowing a configurable etag separator. (#5980)
71fb369 
Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw
Copy link
Contributor Author

gregw commented Feb 18, 2021

Need to disable the tag change if the separator is null or empty.

@gregw gregw reopened this Feb 18, 2021
Jetty 9.4.37 automation moved this from Done to In progress Feb 18, 2021
gregw added a commit that referenced this issue Feb 18, 2021
@gregw
More optional etag gzip fixes for #5979
7d28b42 
IF no separator defined, do not add a suffix to an etag.
Some cleanup of the implementation.
@gregw gregw mentioned this issue Feb 18, 2021
Merged
gregw added a commit that referenced this issue Feb 18, 2021
@gregw
More optional etag gzip fixes for #5979
9543255 
updates from review
gregw added a commit that referenced this issue Feb 18, 2021
@gregw
More optional etag gzip fixes for #5979 (#5986)
324ab66 
* More optional etag gzip fixes for #5979

IF no separator defined, do not add a suffix to an etag.
Some cleanup of the implementation.

* More optional etag gzip fixes for #5979

updates from review
@gregw gregw closed this as completed Feb 18, 2021
Jetty 9.4.37 automation moved this from In progress to Done Feb 18, 2021
This was referenced Mar 10, 2021
Open
Open
Open
Open
Closed
Open
Open
Open
Closed
Open
This was referenced Mar 10, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
@olamy olamy mentioned this issue Jul 25, 2021
Merged
@olamy olamy mentioned this issue Sep 30, 2021
Merged
@olamy olamy mentioned this issue May 6, 2022
Merged
@olamy olamy mentioned this issue May 26, 2022
Merged
This was referenced Jul 25, 2022
Merged
Merged
Merged
@olamy olamy mentioned this issue Aug 13, 2022
Merged
@olamy olamy mentioned this issue Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregw gregw

Labels
Enhancement Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 9.4.37
Done
Milestone
No milestone
1 participant
@gregw