Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache-Control header set by a filter is override by the value from DefaultServlet configuration #5977

Closed
olamy opened this issue Feb 17, 2021 · 1 comment · Fixed by #5978
Closed

Cache-Control header set by a filter is override by the value from DefaultServlet configuration #5977

olamy opened this issue Feb 17, 2021 · 1 comment · Fixed by #5978
Assignees
@olamy
Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement
Projects
Jetty 9.4.37 Jetty 9.4.38
Milestone
9.4.x

Comments

@olamy
Copy link
Member

olamy commented Feb 17, 2021 •
edited

In case some filter set the value of Cache-Control header then the DefaultServlet via ResourceService will override it if configured.
@olamy olamy self-assigned this Feb 17, 2021
@olamy olamy added the Bug For general bugs on Jetty side label Feb 17, 2021
@olamy olamy added this to the 9.4.x milestone Feb 17, 2021
olamy added a commit that referenced this issue Feb 17, 2021
@olamy
Issue #5977 do not force Cache-Control header if already set
f034cee 
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
@olamy olamy changed the title cache-control header set by a filter is override by the value from DefaultServlet configuration Cache-Control header set by a filter is override by the value from DefaultServlet configuration Feb 17, 2021
@joakime joakime added the Sponsored This issue affects a user with a commercial support agreement label Feb 17, 2021
@joakime joakime linked a pull request Feb 17, 2021 that will close this issue
Issue #5977 do not force Cache-Control header if already set #5978
Merged
@joakime joakime added this to To do in Jetty 9.4.37 via automation Feb 17, 2021
@joakime joakime moved this from To do to In progress in Jetty 9.4.37 Feb 17, 2021
olamy added a commit that referenced this issue Feb 17, 2021
@olamy
Issue #5977 do not force Cache-Control header if already set (#5978)
addfbe8 
* Issue #5977 do not force Cache-Control header if already set

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
@olamy
Copy link
Member Author

olamy commented Feb 17, 2021

fixed by addfbe8

@olamy olamy closed this as completed Feb 17, 2021
Jetty 9.4.37 automation moved this from In progress to Done Feb 17, 2021
olamy added a commit that referenced this issue Feb 17, 2021
@olamy
Issue #5977 do not force Cache-Control header if already set (#5978)
5eb17a0 
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
olamy added a commit that referenced this issue Feb 23, 2021
@olamy
fix containsHeader test when it is not instance of Response, Issue #5977
38ef400 
 was partially fixed

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
olamy added a commit that referenced this issue Feb 23, 2021
@olamy
add test for fix containsHeader test when it is not instance of Respo…
b836c2f 
…nse, Issue #5977 was partially fixed

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
gregw added a commit that referenced this issue Feb 23, 2021
@gregw
Efficiency improvements for #5977
9535144 
Improve efficiency for non wrapped response for cache-contro
gregw added a commit that referenced this issue Feb 23, 2021
@gregw
Efficiency improvements for #5977 (#5998)
c0b0f80 
Improve efficiency for non wrapped response for cache-contro
gregw added a commit that referenced this issue Feb 23, 2021
@gregw
Efficiency improvements for #5977
fdb54fa 
Improve efficiency for non wrapped response for cache-contro
gregw added a commit that referenced this issue Feb 23, 2021
@gregw
Efficiency improvements for #5977
16241d7 
Improve efficiency for non wrapped response for cache-contro
This was referenced Mar 10, 2021
Open
Open
Open
Open
Closed
Open
Open
Open
Closed
Open
This was referenced Mar 10, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
@gregw gregw added this to To do in Jetty 9.4.38 via automation Mar 25, 2021
@gregw gregw moved this from To do to Done in Jetty 9.4.38 Mar 25, 2021
@olamy olamy mentioned this issue Jul 25, 2021
Merged
@olamy olamy mentioned this issue Sep 30, 2021
Merged
@olamy olamy mentioned this issue May 6, 2022
Merged
@olamy olamy mentioned this issue May 26, 2022
Merged
This was referenced Jul 25, 2022
Merged
Merged
Merged
@olamy olamy mentioned this issue Aug 13, 2022
Merged
@olamy olamy mentioned this issue Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olamy olamy

Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 9.4.37
Done
Jetty 9.4.38
Done
Milestone
9.4.x
Development

Successfully merging a pull request may close this issue.

Issue #5977 do not force Cache-Control header if already set jetty/jetty.project
2 participants
@olamy @joakime