Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SslConnection should implement getBytesIn()/getBytesOut() #5931

Closed
sbordet opened this issue Jan 29, 2021 · 0 comments · Fixed by #6335 or #6351
Closed

SslConnection should implement getBytesIn()/getBytesOut() #5931

sbordet opened this issue Jan 29, 2021 · 0 comments · Fixed by #6335 or #6351
Assignees
@sbordet
Labels
Sponsored This issue affects a user with a commercial support agreement
Projects
Jetty 9.4.42 FROZEN Jetty 10.0.4/11.0.4 FROZEN

Comments

@sbordet
Copy link
Contributor

sbordet commented Jan 29, 2021

Jetty version
9.4.x

Description
SslConnection does not implement getBytesIn()/getBytesOut() but it should, so that load test reports are accurate in showing how many bytes traveled through the network.

Using IncludeExcludeConnectionStatistics would allow to select what connection needs to be tracked to avoid double-reporting the bytes.
@sbordet sbordet added this to To do in Jetty 9.4.42 FROZEN via automation May 30, 2021
@sbordet sbordet self-assigned this May 30, 2021
@sbordet sbordet added Sponsored This issue affects a user with a commercial support agreement and removed Help Wanted Low Priority labels May 30, 2021
sbordet added a commit that referenced this issue May 30, 2021
@sbordet
Fixes #5931 - SslConnection should implement getBytesIn()/getBytesOut().
f55fb60 
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet linked a pull request May 30, 2021 that will close this issue
Fixes #5931 - SslConnection should implement getBytesIn()/getBytesOut(). #6335
Merged
sbordet added a commit that referenced this issue May 30, 2021
@sbordet
Fixes #5931 - SslConnection should implement getBytesIn()/getBytesOut().
3d9b196 
Make sure the connection is closed before the assertions.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue May 30, 2021
@sbordet
Fixes #5931 - SslConnection should implement getBytesIn()/getBytesOut().
e841775 
Fixed CountDownLatch count.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue May 30, 2021
@sbordet
Fixes #5931 - SslConnection should implement getBytesIn()/getBytesOut().
366bfcf 
Fixed CountDownLatch count again.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue May 31, 2021
@sbordet
Fixes #5931 - SslConnection should implement getBytesIn()/getBytesOut().
cb2d57b 
Updates after review.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Jun 1, 2021
@sbordet
Fixes #5931 - SslConnection should implement getBytesIn()/getBytesOut().
7d04ad2 
Updated ConnectionStatistics to report both the stats of all connections,
and the stats grouped by connection class.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Jun 3, 2021
@sbordet
Fixes #5931 - SslConnection should implement getBytesIn()/getBytesOut().
263a261 
Updates after review.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Jun 3, 2021
@sbordet
Fixes #5931 - SslConnection should implement getBytesIn()/getBytesOut().
7ef65d5 
The TimeoutException message always references the original timeout.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Jun 3, 2021
@sbordet
Fixes #5931 - SslConnection should implement getBytesIn()/getBytesOut…
f902d12 
…(). (#6335)

* Fixes #5931 - SslConnection should implement getBytesIn()/getBytesOut().

Updated ConnectionStatistics to report both the stats of all connections,
and the stats grouped by connection class.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Jun 3, 2021
@sbordet
Fixes #5931 - SslConnection should implement getBytesIn()/getBytesOut…
6c52326 
…(). (#6335)

Updated ConnectionStatistics to report both the stats of all connections,
and the stats grouped by connection class.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
(cherry picked from commit f902d12)
@sbordet sbordet linked a pull request Jun 3, 2021 that will close this issue
Fixes #5931 - SslConnection should implement getBytesIn()/getBytesOut… #6351
Merged
@sbordet sbordet added this to To do in Jetty 10.0.4/11.0.4 FROZEN via automation Jun 3, 2021
@sbordet sbordet moved this from To do to Done in Jetty 9.4.42 FROZEN Jun 3, 2021
Jetty 10.0.4/11.0.4 FROZEN automation moved this from To do to Done Jun 3, 2021
sbordet added a commit that referenced this issue Jun 3, 2021
@sbordet
Fixes #5931 - SslConnection should implement getBytesIn()/getBytesOut…
c151b04 
…(). (#6335)

Updated ConnectionStatistics to report both the stats of all connections,
and the stats grouped by connection class.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
(cherry picked from commit f902d12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 10.0.4/11.0.4 FROZEN
Done
Jetty 9.4.42 FROZEN
Done
Milestone
No milestone
1 participant
@sbordet