Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #5684 Fix and re-enable ServletRequestLogTest. #5877

Merged
merged 1 commit into from Jan 13, 2021
Merged

Issue #5684 Fix and re-enable ServletRequestLogTest. #5877

merged 1 commit into from Jan 13, 2021

Conversation

janbartel
Copy link
Contributor

Part of review of all disabled tests in #5684.

Fix broken ServletRequestLogTest and re-enable it.

@janbartel
Issue #5684 Fix and re-enable ServletRequestLogTest.
995b08a 
Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel added this to In progress in Jetty 9.4.36 via automation Jan 13, 2021
@janbartel janbartel self-assigned this Jan 13, 2021
Jetty 9.4.36 automation moved this from In progress to Reviewer approved Jan 13, 2021
gregw
gregw approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janbartel janbartel merged commit b99eb3f into jetty-9.4.x Jan 13, 2021
Jetty 9.4.36 automation moved this from Reviewer approved to Done Jan 13, 2021
@janbartel janbartel deleted the jetty-9.4.x-5684-fix-servletrequestlogtest branch January 13, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

@joakime joakime Awaiting requested review from joakime

Assignees

@janbartel janbartel

Labels
None yet
Projects
No open projects
Jetty 9.4.36
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janbartel @gregw