Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ManagedSelector report better JMX data #5787

Closed
sbordet opened this issue Dec 10, 2020 · 1 comment · Fixed by #5910
Closed

Make ManagedSelector report better JMX data #5787

sbordet opened this issue Dec 10, 2020 · 1 comment · Fixed by #5910
Assignees
@sbordet
Projects
Jetty 9.4.37

Comments

@sbordet
Copy link
Contributor

sbordet commented Dec 10, 2020

Jetty version
9.4.x

Description
ManagedSelector should be enhanced to report useful information via JMX.

For example:

  1. Number of select() wakeups
  2. How many keys were selected for each wakeup
  3. How many keys each selector manages
  4. How long it takes to process selected keys
  5. How long select() operations lasts (i.e. how long it's "idle")
  6. Etc.
@sbordet
Copy link
Contributor Author

sbordet commented Jan 22, 2021

@gregw @lorban after our investigation, I think it's useful to report (per selector):

  • total keys
  • average selected keys
  • max selected keys
  • number of select() calls

@sbordet sbordet assigned sbordet and unassigned lorban Jan 22, 2021
sbordet added a commit that referenced this issue Feb 3, 2021
@sbordet
Merge pull request #5910 from eclipse/jetty-9.4.x-5787-managedselecto…
a26ad6d 
…r_jmx

Fixes #5787 - Make ManagedSelector report better JMX data.
@sbordet sbordet closed this as completed in 755ec45 Feb 3, 2021
@sbordet sbordet linked a pull request Feb 3, 2021 that will close this issue
Fixes #5787 - Make ManagedSelector report better JMX data. #5910
Merged
@sbordet sbordet added this to To do in Jetty 9.4.37 via automation Feb 3, 2021
@sbordet sbordet moved this from To do to Done in Jetty 9.4.37 Feb 3, 2021
This was referenced Mar 10, 2021
Open
Open
Open
Open
Closed
Open
Open
Open
Closed
Open
Closed
Closed
Closed
Open
Open
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 10, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
@sbordet sbordet mentioned this issue Jun 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
None yet
Projects
No open projects
Jetty 9.4.37
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #5787 - Make ManagedSelector report better JMX data. jetty/jetty.project
2 participants
@sbordet @lorban