Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ByteBufferPool race condition #5778

Merged
merged 1 commit into from Dec 9, 2020

Conversation

lorban
Copy link
Contributor

@lorban lorban commented Dec 9, 2020

Closes #5775

@lorban lorban requested review from gregw and joakime December 9, 2020 09:39
@lorban lorban changed the base branch from jetty-10.0.x to jetty-9.4.x December 9, 2020 09:40
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion, I think "opaque" semantic is fine for Jetty 10, so please use [get|set]Opaque() when merging to 10.

…ne in case the timestamp is read while being modified
@lorban lorban force-pushed the jetty-9.4.x-5775-ByteBufferPool-timestamp-fix branch from 647cae2 to 4151965 Compare December 9, 2020 15:33
@lorban lorban merged commit ea621ce into jetty-9.4.x Dec 9, 2020
@lorban lorban deleted the jetty-9.4.x-5775-ByteBufferPool-timestamp-fix branch December 9, 2020 15:35
@lorban lorban added this to In progress in Jetty 9.4.36 via automation Jan 11, 2021
@lorban lorban moved this from In progress to Done in Jetty 9.4.36 Jan 11, 2021
This was referenced Mar 10, 2021
This was referenced Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Potential data race in ByteBufferPool
2 participants