Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max usage count fixes #5743

Merged
merged 2 commits into from Dec 1, 2020
Merged

max usage count fixes #5743

merged 2 commits into from Dec 1, 2020

Conversation

lorban
Copy link
Contributor

@lorban lorban commented Dec 1, 2020

Closes #5741

@lorban
fix bug that messes up the max usage count when the entries' max usag…
0ff1bfd 
…e counter overflows

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban requested review from gregw and sbordet December 1, 2020 09:26
gregw
gregw requested changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the clean in the setter, but I think it can be done better with a single grab of the lock.
But if that is too complex, I'd accept the current impl... but only after you try doing it with one lock grab.

jetty-util/src/main/java/org/eclipse/jetty/util/Pool.java Outdated Show resolved Hide resolved
@lorban
Copy link
Contributor Author

lorban commented Dec 1, 2020 •
edited

I like the clean in the setter, but I think it can be done better with a single grab of the lock.
But if that is too complex, I'd accept the current impl... but only after you try doing it with one lock grab.

What do you mean with "with a single grab of the lock"?

@lorban
sweep the entries list when the max usage count is changed
44e6f4a 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban force-pushed the jetty-9.4.x-5741-PoolMaxUsageOverflow branch from be5de28 to 44e6f4a Compare December 1, 2020 14:18
@lorban lorban merged commit 6199c97 into jetty-9.4.x Dec 1, 2020
@lorban lorban deleted the jetty-9.4.x-5741-PoolMaxUsageOverflow branch December 1, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

@sbordet sbordet Awaiting requested review from sbordet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lorban @gregw