Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5739 Remove distribution from doco #5740

Merged
merged 5 commits into from Dec 2, 2020
Merged

Fix #5739 Remove distribution from doco #5740

merged 5 commits into from Dec 2, 2020

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Nov 30, 2020

Fix #5739 Remove distribution from doco
Mostly mechanical fixes

@gregw gregw requested a review from joakime December 2, 2020 08:14
@gregw gregw marked this pull request as ready for review December 2, 2020 08:14
@gregw
Copy link
Contributor Author

gregw commented Dec 2, 2020

I don't think we should delay to make this perfect, specially in the old_docs.
We need to make it not wrong as much as possible and continue to update docs after this PR is merged

@gregw
Fix #5739 Remove distribution from doco
1768bd8 
Mostly mechanical fixes
@gregw gregw force-pushed the jetty-10.0.x-5739-Remove-distribution-from-doco branch from 6492370 to 1768bd8 Compare December 2, 2020 08:17
@joakime joakime added this to To Do in Jetty 10.0.0 via automation Dec 2, 2020
@joakime joakime moved this from To Do to In Progress in Jetty 10.0.0 Dec 2, 2020
@joakime joakime moved this from In Progress to In Review in Jetty 10.0.0 Dec 2, 2020
@joakime
Fixing comment
ddef266 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime
Updating example output
c90690a 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
joakime requested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a few updates.
I'll submit a few followup commits with them.

jetty-documentation/src/main/asciidoc/old_docs/logging/dump-tool.adoc Outdated Show resolved Hide resolved
jetty-documentation/src/main/asciidoc/old_docs/logging/dump-tool.adoc Outdated Show resolved Hide resolved
jetty-documentation/src/main/asciidoc/old_docs/logging/dump-tool.adoc Outdated Show resolved Hide resolved
jetty-documentation/src/main/asciidoc/old_docs/logging/dump-tool.adoc Outdated Show resolved Hide resolved
joakime
joakime approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with the changes as they currently stand.

@joakime
Copy link
Contributor

joakime commented Dec 2, 2020

@gregw once we get a green build from CI, I'll merge this.

@joakime joakime merged commit 0a034db into jetty-10.0.x Dec 2, 2020
Jetty 10.0.0 automation moved this from In Review to Done Dec 2, 2020
@joakime joakime deleted the jetty-10.0.x-5739-Remove-distribution-from-doco branch December 2, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakime joakime joakime approved these changes

@janbartel janbartel Awaiting requested review from janbartel

@sbordet sbordet Awaiting requested review from sbordet

Assignees

@joakime joakime

@janbartel janbartel

@sbordet sbordet

@WalkerWatch WalkerWatch

Labels
Documentation
Projects
No open projects
Jetty 10.0.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jetty-distribution is not created when building 11.0.0.beta3
5 participants
@gregw @joakime @janbartel @sbordet @WalkerWatch