Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetty-dir.css not found when using JPMS #5488

Closed
sbordet opened this issue Oct 22, 2020 · 0 comments · Fixed by #5491
Closed

jetty-dir.css not found when using JPMS #5488

sbordet opened this issue Oct 22, 2020 · 0 comments · Fixed by #5491
Assignees

Comments

@sbordet
Copy link
Contributor

sbordet commented Oct 22, 2020

Jetty version
9.4.x

Description
jetty-dir.css provides a minimal CSS for directory listing.
It resides in the jetty-util module.

When running Jetty with --jpms, a directory listing page will request jetty-dir.css but a 404 is returned.

My guess is that because of JPMS, the file won't be found unless module jetty.util opens its resources to jetty-servlet, which is probably the module that attempts to load it from the class-path.
If that's the case, jetty-dir.css should be moved to jetty-servlet.

A jetty-home test would be great.

@sbordet sbordet self-assigned this Oct 22, 2020
@sbordet sbordet linked a pull request Oct 22, 2020 that will close this issue
@sbordet sbordet added this to To do in Jetty 9.4.34 via automation Oct 22, 2020
@joakime joakime moved this from To do to In progress in Jetty 9.4.34 Oct 22, 2020
@gregw gregw removed this from In progress in Jetty 9.4.34 Nov 2, 2020
sbordet added a commit that referenced this issue Nov 2, 2020
Fixes #5488 - jetty-dir.css not found when using JPMS.
@sbordet sbordet closed this as completed in 4a4a73d Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant