Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #5320 - using jetty-websocket-httpclient.xml within webapp #5374

Merged
merged 13 commits into from Nov 2, 2020
Merged

Issue #5320 - using jetty-websocket-httpclient.xml within webapp #5374

merged 13 commits into from Nov 2, 2020

Conversation

lachlan-roberts
Copy link
Contributor

Issue #5320

Run the jetty-websocket-httpclient.xml with server class access if WebAppClassLoader is available.

@lachlan-roberts
Issue #5320 - reproduce failure to load httpClient for WebSocketClien…
00f05cb 
…t in webapp

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
Issue #5320 - Run jetty-websocket-httpclient.xml with server class ac…
5b96f6f 
…cess.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts added this to In progress in Jetty 9.4.33 via automation Oct 1, 2020
@lachlan-roberts lachlan-roberts marked this pull request as ready for review October 6, 2020 03:23
@lachlan-roberts lachlan-roberts requested review from gregw and sbordet and removed request for gregw October 6, 2020 03:31
Jetty 9.4.33 automation moved this from In progress to Review in progress Oct 12, 2020
@lachlan-roberts
Copy link
Contributor Author

@sbordet you asked me to add the case where we provide the websocket client classes in WEB-INF/lib, but the webapp still uses the server versions of org.eclipse.jetty.websocket. classes. So it is basically unusable, I get ClassCastException and LinkageError.

Don't you use some shaded jars in cometd to get around this problem?

@lachlan-roberts
Parameterize testWebsocketClientInWebapp over both http and https
26f4062 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-9.4.x-53…
6cd70ce 
…20-WebSocketHttpClient
@lachlan-roberts
Issue #5320 - use HttpClient classloader to load jetty-websocket-http…
1b07c84 
…client.xml

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
Issue #5320 - also test WebSocketClient on server from WEB-INF/lib
4cb475c 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@joakime joakime removed this from Review in progress in Jetty 9.4.33 Oct 22, 2020
@joakime joakime added this to In progress in Jetty 9.4.34 via automation Oct 22, 2020
@joakime joakime moved this from In progress to Review in progress in Jetty 9.4.34 Oct 22, 2020
@joakime joakime linked an issue Oct 22, 2020 that may be closed by this pull request
Using WebSocketClient with jetty-websocket-httpclient.xml in a Jetty web application causes ClassCastException #5320
Closed
@lachlan-roberts
Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-9.4.x-53…
3c3fcc3 
…20-WebSocketHttpClient

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
update version to 9.4.34-SNAPSHOT
59883af 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-9.4.x-53…
458d67e 
…20-WebSocketHttpClient
sbordet
sbordet requested changes Nov 2, 2020
View reviewed changes
...cket-client/src/main/java/org/eclipse/jetty/websocket/client/XmlBasedHttpClientProvider.java Outdated Show resolved Hide resolved
...n/src/main/java/org/eclipse/jetty/websocket/common/extensions/WebSocketExtensionFactory.java
@@ -42,10 +37,8 @@

public class WebSocketExtensionFactory extends ExtensionFactory implements LifeCycle, Dumpable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class extends a deprecated class -- should this class be deprecated as well?

...ed-webapp/src/main/java/org/eclipse/jetty/tests/webapp/websocket/WebSocketClientServlet.java Outdated Show resolved Hide resolved
...ed-webapp/src/main/java/org/eclipse/jetty/tests/webapp/websocket/WebSocketClientServlet.java Outdated Show resolved Hide resolved
.../test-distribution/src/test/java/org/eclipse/jetty/tests/distribution/DistributionTests.java Show resolved Hide resolved
.../test-distribution/src/test/java/org/eclipse/jetty/tests/distribution/DistributionTests.java Show resolved Hide resolved
@lachlan-roberts
changes from review
60c56d8 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Jetty 9.4.34 automation moved this from Review in progress to Reviewer approved Nov 2, 2020
@lachlan-roberts lachlan-roberts merged commit 12f3c45 into jetty-9.4.x Nov 2, 2020
Jetty 9.4.34 automation moved this from Reviewer approved to Done Nov 2, 2020
@lachlan-roberts lachlan-roberts deleted the jetty-9.4.x-5320-WebSocketHttpClient branch November 2, 2020 13:30
@lachlan-roberts lachlan-roberts mentioned this pull request Nov 3, 2020
Merged
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet approved these changes

@gregw gregw Awaiting requested review from gregw

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Jetty 9.4.34
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using WebSocketClient with jetty-websocket-httpclient.xml in a Jetty web application causes ClassCastException
2 participants
@lachlan-roberts @sbordet