Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClient should handle unsolicited responses #5152

Closed
sbordet opened this issue Aug 13, 2020 · 1 comment · Fixed by #5166
Closed

HttpClient should handle unsolicited responses #5152

sbordet opened this issue Aug 13, 2020 · 1 comment · Fixed by #5166
Assignees
@sbordet
Labels
Sponsored This issue affects a user with a commercial support agreement
Projects
Jetty 9.4.32

Comments

@sbordet
Copy link
Contributor

sbordet commented Aug 13, 2020

Jetty version
9.4.x

Description
HAProxy can be configured to idle timeout a connection with an HTTP response 408.

When HttpClient receives this unsolicited response, it does not have a matching request and fails to close the connection.
Reports are that the connection was closed at least in 9.4.20.

Investigate this behavior and perhaps make it configurable - these unsolicited responses are indistinguishable from real responses.
@sbordet sbordet added the Sponsored This issue affects a user with a commercial support agreement label Aug 13, 2020
@sbordet sbordet self-assigned this Aug 13, 2020
@sbordet
Copy link
Contributor Author

sbordet commented Aug 18, 2020

Since Jetty 9.4.21 and the fix for #4113, the client does not close anymore the connection when receiving "garbage" bytes from the server, because it has to process the additional TLS bytes.

@sbordet sbordet linked a pull request Aug 18, 2020 that will close this issue
Fixes #5152 - HttpClient should handle unsolicited responses. #5166
Merged
@sbordet sbordet added this to To do in Jetty 9.4.32 via automation Aug 18, 2020
sbordet added a commit that referenced this issue Aug 26, 2020
@sbordet
Merge pull request #5166 from eclipse/jetty-9.4.x-5152-handle_unsolic…
7cf6058 
…ited_response

Fixes #5152 - HttpClient should handle unsolicited responses.
Jetty 9.4.32 automation moved this from To do to Done Aug 26, 2020
@djvanpelt djvanpelt mentioned this issue May 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 9.4.32
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #5152 - HttpClient should handle unsolicited responses. jetty/jetty.project
1 participant
@sbordet