Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Listeners to aid in tracking timings within ServletContext and WebApp #5032

Closed
joakime opened this issue Jul 8, 2020 · 2 comments
Closed

Introduce Listeners to aid in tracking timings within ServletContext and WebApp #5032

joakime opened this issue Jul 8, 2020 · 2 comments
Assignees
@joakime
Labels
Enhancement Sponsored This issue affects a user with a commercial support agreement Stale For auto-closed stale issues and pull requests

Comments

@joakime
Copy link
Contributor

joakime commented Jul 8, 2020

Jetty version
9.4.30

Description
While the HttpChannel.Listener is very powerful, it doesn't have visibility into Servlet/WebApp specific concepts to aide in tracking performance behavior within specific Servlet/WebApp components.

Introduce a Listener (or two) that will :

  • expose startup timing. (overall WebApp timing, and ServletContext specific init timing)
  • expose individual component init timing (for Servlet / Filter / Listener inits)
  • expose WebApp configuration timing (for Configuration steps that can often take a long time to process. eg: annotation/bytecode scanning, jndi/datasource setup, etc)
  • expose tracking of Enter/Exit for Filter.doChain() and Servlet.service() call events.
@joakime joakime added Enhancement Sponsored This issue affects a user with a commercial support agreement labels Jul 8, 2020
@joakime joakime self-assigned this Jul 8, 2020
@joakime joakime added this to To do in Jetty 9.4.31 via automation Jul 8, 2020
@joakime joakime changed the title Introduce Listeners to aide in tracking timings within ServletContext and WebApp Introduce Listeners to aid in tracking timings within ServletContext and WebApp Jul 8, 2020
joakime added a commit that referenced this issue Jul 8, 2020
@joakime
Issue #5032 - Servlet / WebApp Metrics Listener Support
c4bedc4 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Jul 8, 2020
@joakime
Issue #5032 - Fixing License and javadoc
633111d 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime linked a pull request Jul 8, 2020 that will close this issue
Issue #5032 - Servlet / WebApp Metrics Listener Support #5033
Closed
@joakime joakime added this to In progress in Jetty 9.4.32 Jul 22, 2020
@joakime joakime removed this from To do in Jetty 9.4.31 Jul 22, 2020
joakime added a commit that referenced this issue Aug 21, 2020
@joakime
Issue #5032 - More work towards wrapper based extensible ServletContext
1e6c168 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Sep 14, 2020
@joakime
Issue #5032 - Use variable
5310d35 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Sep 14, 2020
@joakime
Issue #5032 - More work on events for context start/ready
d35d676 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Sep 15, 2020
@joakime
Issue #5032 - WebAppContext & Configuration hooks added
eced4cc 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Sep 15, 2020
@joakime
Issue #5032 - Minimal Extensible Web App changes
30caaba 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Sep 15, 2020
@joakime
Issue #5032 - Don't wrap if there is no ServletContextHandler
439d3f9 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Sep 16, 2020
@joakime
Issue #5032 - Moving wrap/unwrap to BaseHolder
d340c1e 
+ Fixing Filter destroy call order

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Sep 16, 2020
@joakime
Issue #5032 - Using BaseHolder template T vs C
c569c87 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Sep 16, 2020
@joakime
Issue #5032 - Updating based on review with @gregw and @janb
9d4b92b 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Sep 17, 2020
@joakime
Issue #5032 - Adding requested javadoc
d08831b 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Sep 17, 2020
@joakime
Issue #5032 - Minimal Extensible Web App changes
59976dc 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Sep 17, 2020
@joakime
Merge pull request #5273 from eclipse/jetty-9.4.x-5032-minimal-extens…
0db3663 
…ible-web-apps

Issue #5032 - Minimal Extensible Web App changes
@joakime joakime added this to To do in Jetty 9.4.33 via automation Sep 17, 2020
@joakime joakime removed this from In progress in Jetty 9.4.32 Sep 17, 2020
@sbordet sbordet mentioned this issue Oct 3, 2020
Closed
@joakime joakime removed this from To do in Jetty 9.4.33 Oct 14, 2020
@joakime joakime added this to To do in Jetty 9.4.34 via automation Oct 14, 2020
@gregw gregw removed this from To do in Jetty 9.4.34 Nov 2, 2020
@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Jul 21, 2021
@github-actions
Copy link

This issue has been closed due to it having no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Enhancement Sponsored This issue affects a user with a commercial support agreement Stale For auto-closed stale issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #5032 - Servlet / WebApp Metrics Listener Support jetty/jetty.project
1 participant
@joakime