Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty WebSocket API onMessage annotation does not support partial messages. #4772

Closed
lachlan-roberts opened this issue Apr 14, 2020 · 1 comment · Fixed by #6357
Closed

Jetty WebSocket API onMessage annotation does not support partial messages. #4772

lachlan-roberts opened this issue Apr 14, 2020 · 1 comment · Fixed by #6357
Assignees
@lachlan-roberts
Projects
Jetty 10.0.5/11.0.5 FROZEN

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version
10.0.x

Description
The Jetty WebSocket API @OnWebSocketMessage annotation does not support partial messages, while the Javax API does support this. To use partial messages you must implement WebSocketPartialListener.

We should consider adding support for partial messages for the OnWebSocketMessage annotation in the jetty ws API.
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Jun 2, 2021
@joakime joakime removed the Stale For auto-closed stale issues and pull requests label Jun 2, 2021
@lachlan-roberts lachlan-roberts self-assigned this Jun 3, 2021
lachlan-roberts added a commit that referenced this issue Jun 4, 2021
@lachlan-roberts
Issue #4772 - support partial messages for Jetty WS API annotations
bab1a78 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Jun 4, 2021
Merged
@sbordet sbordet added this to To do in Jetty 10.0.5/11.0.5 FROZEN via automation Jun 4, 2021
@gregw gregw moved this from To do to Review in progress in Jetty 10.0.5/11.0.5 FROZEN Jun 10, 2021
Jetty 10.0.5/11.0.5 FROZEN automation moved this from Review in progress to Done Jun 10, 2021
sbordet pushed a commit that referenced this issue Jun 10, 2021
@lachlan-roberts
Issue #4772 - support partial messages for Jetty WS API annotations (#…
6dea025 
…6357)

* Issue #4772 - support partial messages for Jetty WS API annotations

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
None yet
Projects
No open projects
Jetty 10.0.5/11.0.5 FROZEN
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #4772 - support partial messages for Jetty WS API annotations jetty/jetty.project
2 participants
@joakime @lachlan-roberts