Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GZipHandler not excluding inflation for specified paths #4414

Closed
Auo opened this issue Dec 11, 2019 · 4 comments · Fixed by #7873
Closed

GZipHandler not excluding inflation for specified paths #4414

Auo opened this issue Dec 11, 2019 · 4 comments · Fixed by #7873
Assignees

Comments

@Auo
Copy link

Auo commented Dec 11, 2019

Jetty version
9.4.24.v20191120

Java version
openjdk 11.0.3 2019-04-16
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.3+7)

OS type/version
macOS Catalina
version 10.15.1

Description
GZipHandler::addExcludedPaths does not exclude inflation for specified paths when GZipHandler::setInflateBufferSize has been set.

A new method, addExcludedInflationPaths would be very useful or to make sure the paths from addExcludedPaths also apply when checking if the request should be inflated.

Usecase
We want to inflate requests on certain paths, but on other paths we want to handle the inflation ourselves.

Thanks!

@stale
Copy link

stale bot commented Dec 11, 2020

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Dec 11, 2020
@sbordet
Copy link
Contributor

sbordet commented Dec 11, 2020

@lachlan-roberts isn't this feature present already?

@stale stale bot removed the Stale For auto-closed stale issues and pull requests label Dec 11, 2020
@github-actions
Copy link

github-actions bot commented Mar 3, 2022

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Mar 3, 2022
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Mar 3, 2022
@joakime
Copy link
Contributor

joakime commented Mar 3, 2022

Current GzipHandler in Jetty 10 and 11 will always inflate if the request contains Content-Encoding: gzip header.
There's no filtering/include/exclude for inflation for anything (path, method, mime-type, etc)

lachlan-roberts added a commit that referenced this issue Apr 12, 2022
…flation.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue May 9, 2022
…Exclusion

Issue #4414 - add option to exclude paths from GzipHandler request inflation
lachlan-roberts added a commit that referenced this issue May 9, 2022
…flation.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants