Fixes #4113 - HttpClient fails with JDK 13 and TLS 1.3. #4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Now forwarding the fillable event rather than assuming that is due to garbage bytes or by a server close. This ensures that a HTTP read consumes the TLS bytes and the `NewSessionTicket` message. 2. Avoid to set the `SslConnection` onto the `EndPoint` in `SslClientConnectionFactory` - this allows upgrades to work properly, for example when tunnelling through a secure proxy. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
joakime
reviewed
Sep 23, 2019
| @@ -97,7 +97,6 @@ public void setAllowMissingCloseMessage(boolean allowMissingCloseMessage) | |||
| context.put(SSL_ENGINE_CONTEXT_KEY, engine); | |||
|
|
|||
| SslConnection sslConnection = newSslConnection(byteBufferPool, executor, endPoint, engine); | |||
| endPoint.setConnection(sslConnection); | |||
There was a problem hiding this comment.
Is this right?
It looks like a bug to remove this line.
joakime
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to garbage bytes or by a server close. This ensures that a HTTP read
consumes the TLS bytes and the
NewSessionTicketmessage.SslConnectiononto theEndPointinSslClientConnectionFactory- this allows upgrades to work properly,for example when tunnelling through a secure proxy.
Signed-off-by: Simone Bordet simone.bordet@gmail.com