Issue #4047 Graceful Write #4100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test to reproduce issue Fixed bug from #2772 where output was shutdown on DONE without checking for END. Fixed aggregation logic to aggregate last write if aggregation already started. Signed-off-by: Greg Wilkins <gregw@webtide.com>
…47-graceful-ab-write
Signed-off-by: Greg Wilkins <gregw@webtide.com>
lachlan-roberts
requested changes
Sep 23, 2019
Signed-off-by: Greg Wilkins <gregw@webtide.com>
jetty-util/src/main/java/org/eclipse/jetty/util/thread/QueuedThreadPool.java
Outdated
Show resolved
Hide resolved
lachlan-roberts
requested changes
Sep 23, 2019
jetty-util/src/main/java/org/eclipse/jetty/util/component/Graceful.java
Outdated
Show resolved
Hide resolved
Reverted accidental commit and fixed javadoc error. Signed-off-by: Greg Wilkins <gregw@webtide.com>
joakime
reviewed
Sep 24, 2019
joakime
reviewed
Sep 24, 2019
jetty-server/src/test/java/org/eclipse/jetty/server/GracefulStopTest.java
Outdated
Show resolved
Hide resolved
joakime
reviewed
Sep 24, 2019
jetty-http/src/main/java/org/eclipse/jetty/http/HttpGenerator.java
Outdated
Show resolved
Hide resolved
Improved comment Started stopper earlier Signed-off-by: Greg Wilkins <gregw@webtide.com>
janbartel
requested changes
Sep 24, 2019
jetty-server/src/main/java/org/eclipse/jetty/server/HttpConnection.java
Outdated
Show resolved
Hide resolved
|
@lachlan-roberts @janbartel can you both rerereview please? |
janbartel
requested changes
Sep 25, 2019
jetty-server/src/main/java/org/eclipse/jetty/server/HttpConnection.java
Outdated
Show resolved
Hide resolved
…47-graceful-ab-write Signed-off-by: Greg Wilkins <gregw@webtide.com>
Improved comments and clarify conditions Signed-off-by: Greg Wilkins <gregw@webtide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been branched off #4094, which has started to address bigger graceful stop issues.
This PR address just the bug introduced in #2772:
Signed-off-by: Greg Wilkins gregw@webtide.com