Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3734 - throw ISE for WebSocket suspend after close (jetty-9.4) #4098

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Issue #3734 - throw ISE for WebSocket suspend after close (jetty-9.4) #4098

merged 2 commits into from
Sep 25, 2019

Conversation

lachlan-roberts
Copy link
Contributor

Issue #3734

Changes from #4095 for jetty-9.4.x.
Make suspending or resuming after close result in ISE.

Signed-off-by: Lachlan Roberts lachlan@webtide.com

@lachlan-roberts
Issue #3734 - throw ISE for WebSocket suspend after close
e8265b8 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts changed the title Issue #3734 - throw ISE for WebSocket suspend after close Issue #3734 - throw ISE for WebSocket suspend after close (jetty-9) Sep 18, 2019
@lachlan-roberts lachlan-roberts changed the title Issue #3734 - throw ISE for WebSocket suspend after close (jetty-9) Issue #3734 - throw ISE for WebSocket suspend after close (jetty-9.4) Sep 18, 2019
@lachlan-roberts
Copy link
Contributor Author

lachlan-roberts commented Sep 18, 2019 •
edited

While testing this I ran into issue #4096. Although it does not seem to be related to these changes.

Update: replicated #4096 in jetty-9.4.x branch so not caused by these changes.

@lachlan-roberts
Issue #3734 - suspend is error if onClose() has been called
282c301 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
joakime
joakime approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes, the test case changes as well.

@lachlan-roberts lachlan-roberts merged commit 3edc6c9 into jetty-9.4.x Sep 25, 2019
@lachlan-roberts lachlan-roberts deleted the jetty-9.4.x-3734-WebSocketSuspend branch September 25, 2019 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw requested changes

@joakime joakime joakime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lachlan-roberts @gregw @joakime