Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websocket suspend when input closed #3734

Closed
lachlan-roberts opened this issue Jun 5, 2019 · 3 comments
Closed

websocket suspend when input closed #3734

lachlan-roberts opened this issue Jun 5, 2019 · 3 comments
Assignees
@lachlan-roberts
Projects
Jetty 9.4.21

Comments

@lachlan-roberts
Copy link
Contributor

suspending a WebSocket when it is already input closed has different behavior from jetty-9 to jetty-10

  • jetty-10 an ISE is thrown
  • jetty-9 it is a no-op

SuspendResumeTest.testSuspendAfterClose() has been disabled in jetty-10 as I was not sure which approach was correct.
@gregw
Copy link
Contributor

gregw commented Jun 5, 2019

I think ISE is probably the most correct API choice... but if there is need we could maintain behaviour with jetty-9 as no-op is OKish. @joakime your thoughts?

@joakime
Copy link
Contributor

joakime commented Jun 5, 2019

I personally like the ISE.
It sends a clear message to the application user that they need to tighten up their suspend logic.
They can choose to correct their implementation, or ignore the ISE.

lachlan-roberts added a commit that referenced this issue Sep 16, 2019
@lachlan-roberts
Fixes #3734 - throw ISE for WebSocket suspend after close
4c33b21 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Sep 16, 2019
@lachlan-roberts
Issue #3734 - throw ISE for WebSocket suspend after close
b0e7b37 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Sep 17, 2019
@lachlan-roberts
Issue #3734 - throw ISE for WebSocket suspend after close
014b0b9 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Sep 18, 2019
Merged
lachlan-roberts added a commit that referenced this issue Sep 18, 2019
@lachlan-roberts
Issue #3734 - throw ISE for WebSocket suspend after close
e8265b8 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Sep 18, 2019
Merged
lachlan-roberts added a commit that referenced this issue Sep 24, 2019
@lachlan-roberts
Issue #3734 - suspend is error if onClose() has been called
282c301 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Sep 25, 2019
@lachlan-roberts
Issue #3734 - throw ISE for WebSocket suspend after close (jetty-9.4) (…
3edc6c9 
…#4098)

* Issue #3734 - throw ISE for WebSocket suspend after close

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>

* Issue #3734 - suspend is error if onClose() has been called

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@joakime joakime added this to To do in Jetty 9.4.21 via automation Sep 25, 2019
@joakime joakime moved this from To do to Done in Jetty 9.4.21 Sep 25, 2019
@lachlan-roberts lachlan-roberts self-assigned this Sep 26, 2019
lachlan-roberts added a commit that referenced this issue Oct 7, 2019
@lachlan-roberts
Issue #3734 - throw ISE for WebSocket suspend after close (#4095)
d472649 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
Copy link
Contributor Author

changed suspend while closed to throw ISE in both jetty-9.4.x and jetty-10.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
None yet
Projects
No open projects
Jetty 9.4.21
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gregw @joakime @lachlan-roberts