Jetty 9.4.x 2140 infinispan expired sessions #3457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…140-InfinispanExpiredSessions Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
…40-InfinispanExpiredSessions
…40-InfinispanExpiredSessions Signed-off-by: Jan Bartel <janb@webtide.com>
…40-InfinispanExpiredSessions Signed-off-by: Jan Bartel <janb@webtide.com>
…40-InfinispanExpiredSessions
deserialisation; classname of hotrod remote cache has changed Signed-off-by: Jan Bartel <janb@webtide.com>
just with query.
…40-InfinispanExpiredSessions
…40-InfinispanExpiredSessions Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
…40-InfinispanExpiredSessions Signed-off-by: Jan Bartel <janb@webtide.com>
…40-InfinispanExpiredSessions Signed-off-by: Jan Bartel <janb@webtide.com>
…40-InfinispanExpiredSessions
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
…40-InfinispanExpiredSessions
…40-InfinispanExpiredSessions Signed-off-by: Jan Bartel <janb@webtide.com>
olamy
approved these changes
Mar 20, 2019
...y-hazelcast/src/main/java/org/eclipse/jetty/hazelcast/session/HazelcastSessionDataStore.java
Outdated
Show resolved
Hide resolved
...y-hazelcast/src/main/java/org/eclipse/jetty/hazelcast/session/HazelcastSessionDataStore.java
Outdated
Show resolved
Hide resolved
...y-hazelcast/src/main/java/org/eclipse/jetty/hazelcast/session/HazelcastSessionDataStore.java
Show resolved
Hide resolved
...an-sessions/src/test/java/org/eclipse/jetty/server/session/ClusteredOrphanedSessionTest.java
Outdated
Show resolved
Hide resolved
| @@ -24,6 +24,7 @@ | |||
| import org.eclipse.jetty.session.infinispan.InfinispanSessionDataStoreFactory; | |||
| import org.junit.jupiter.api.AfterAll; | |||
| import org.junit.jupiter.api.BeforeAll; | |||
| import org.junit.jupiter.api.Test; | |||
.../test/java/org/eclipse/jetty/server/session/remote/RemoteClusteredSessionScavengingTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| baos = new ByteArrayOutputStream(); | ||
| IO.copy(is, baos); | ||
| is.close(); |
Signed-off-by: Jan Bartel <janb@webtide.com>
…40-InfinispanExpiredSessions
janbartel
changed the title
|
I've just found an issue with hazelcast, so don't merge this PR yet until I can resolve it. Basically, the problem is that if I enable indexing on the SessionData.expiry field, then for some reason, hazelcast then uses a separate thread to re-read the SessionData after storing it! So far I haven't been able to find a way to avoid this - I may have to make it configurable whether to support queries on hazelcast, with the documented caveat that if you do, you won't be able to store session attributes of classes that exist only inside the webapp. |
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
…40-InfinispanExpiredSessions
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
environment work for serialization/deserialization. Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
…40-InfinispanExpiredSessions Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel
changed the title
Signed-off-by: Jan Bartel <janb@webtide.com>
…40-InfinispanExpiredSessions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2140
Adds the ability to Infinispan and Hazelcast to query to find expired sessions, as per the other SessionDataStores. This means that sessions can be scavenged by jetty (rather than relying on configuring infinispan or hazelcast with time-to-live on each entry), so HttpSessionListeners can be correctly called when the sessions are scavenged.
At the same time, infinispan has been updated to version 9.4.8, and support for the old infinispan-7 dropped.