Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImmutableMapFactory missing withMap, ofMapIterable and withMapIterable #738

Open
donraab opened this issue Jul 28, 2019 · 6 comments · May be fixed by #819
Open

ImmutableMapFactory missing withMap, ofMapIterable and withMapIterable #738

donraab opened this issue Jul 28, 2019 · 6 comments · May be fixed by #819
Labels
enhancement good first issue help wanted minor-version tech-debt

Comments

@donraab
Copy link
Contributor

donraab commented Jul 28, 2019

There are three methods missing on ImmutableMapFactory interface. These are the methods on MutableMapFactory.

<K, V> MutableMap<K, V> ofMap(Map<? extends K, ? extends V> map);
<K, V> MutableMap<K, V> withMap(Map<? extends K, ? extends V> map);
<K, V> MutableMap<K, V> ofMapIterable(MapIterable<? extends K, ? extends V> mapIterable);
<K, V> MutableMap<K, V> withMapIterable(MapIterable<? extends K, ? extends V> mapIterable);

These are currently the methods available on ImmutableMapFactory.

<K, V> ImmutableMap<K, V> ofMap(Map<K, V> map);
<K, V> ImmutableMap<K, V> ofAll(Map<K, V> map);
<K, V> ImmutableMap<K, V> withAll(Map<K, V> map);

The ofAll and withAll methods should be deprecated on ImmutableMapFactory and withMap, ofMapIterable and withMapIterable should be added.
@motlin
Copy link
Contributor

motlin commented Jul 29, 2019

We should also fix the generics on ofMap(), probably in a major version.

@nikhilnanivadekar
Copy link
Contributor

I think next release should just be 11.0 instead of a minor version. It’s much easier to move forward with this philosophy. Thoughts?

@motlin
Copy link
Contributor

motlin commented Jul 29, 2019

Starting on a major release is a commitment to not do any release for a while. I thought 9.1.0 and 9.2.0 went well.

On the other hand, most of the work of doing a release falls on you and it doesn't seem trivial, so I understand. It's also an acknowledgement of something that may already be the case, that we won't release for ~6 months whether it's major or minor.

@prathasirisha
Copy link
Contributor

Would be interested to pick this ticket for my first contribution.
@nikhilnanivadekar , @donraab - Can you assign the ticket to me?

@kedar-joshi kedar-joshi linked a pull request Mar 8, 2020 that will close this issue
Open
@im-prince
Copy link

can u assign me this issue

@Rishabh-mikku
Copy link

@donraab I have understood this issue so can you please assign this issue to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted minor-version tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing methods to ImmutableMapFactory
6 participants
@motlin @donraab @nikhilnanivadekar @prathasirisha @Rishabh-mikku @im-prince