Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tycho Packaging plugin is packaging .gitignore #966

Closed
sravanlakkimsetti opened this issue May 19, 2022 · 7 comments · Fixed by #967, #968 or #972
Closed

Tycho Packaging plugin is packaging .gitignore #966

sravanlakkimsetti opened this issue May 19, 2022 · 7 comments · Fixed by #967, #968 or #972
Milestone

Comments

@sravanlakkimsetti
Copy link

We are seeing the following log in platform build https://download.eclipse.org/eclipse/downloads/drops4/I20220518-1100/buildlogs/comparatorlogs/buildtimeComparatorUnanticipated.log.txt

In my opinion .gitignore should not get packaged in to plugin jar. Something went wrong here

Notifications:
@akurtakov @laeubi

@akurtakov
Copy link
Member

This is caused by 34f6670 , more specifically codehaus-plexus/plexus-utils#174 . I'll have a fix shortly.

@sravanlakkimsetti
Copy link
Author

Still there is a problem
Comparator differences from current build
/home/jenkins/agent/workspace/I-build-4.24/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/cje-production/siteDir/eclipse/downloads/drops4/I20220520-0600
compared to reference repo at
https://download.eclipse.org/eclipse/updates/4.24-I-builds

  1. eclipse.jdt.ui/org.eclipse.jdt.ui.tests
    no-classifier: different
    org/eclipse/jdt/ui/tests/chkpii/.gitignore: not present in baseline
    classifier-sources: not present in baseline
    The main artifact has been replaced with the baseline version.
    The following attached artifacts are not present in the baseline and have been removed: [sources]

@akurtakov akurtakov reopened this May 20, 2022
akurtakov added a commit to akurtakov/tycho that referenced this issue May 23, 2022
Adjustment after change in plexus-utils.
Really fixes eclipse-tycho#966 .
akurtakov added a commit to akurtakov/tycho that referenced this issue May 23, 2022
Adjustment after change in plexus-utils.
Really fixes eclipse-tycho#966 .
akurtakov added a commit that referenced this issue May 23, 2022
Adjustment after change in plexus-utils.
Really fixes #966 .
@sravanlakkimsetti
Copy link
Author

Still an issue

Comparator differences from current build
	/home/jenkins/agent/workspace/I-build-4.24/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/cje-production/siteDir/eclipse/downloads/drops4/I20220523-0320
compared to reference repo at 
	https://download.eclipse.org/eclipse/updates/4.24-I-builds

1.  eclipse.platform.ui/tests/org.eclipse.ui.tests
   no-classifier: different
      .gitignore: present in baseline only
   classifier-sources: not present in baseline
    The main artifact has been replaced with the baseline version.
    The following attached artifacts are not present in the baseline and have been removed: [sources]

@mickaelistria
Copy link
Contributor

.gitignore: present in baseline only

Bundle needs to be touched and get a new qualifier for newer build (without .gitignore) to be produced and published

@akurtakov
Copy link
Member

Right, commit eclipse-platform/eclipse.platform.ui@d5b54bc caused the .gitignore to be added and not shown as comparator error. I'll touch the bundle.

@sravanlakkimsetti
Copy link
Author

oops sorry. I will do that now. thanks

@sravanlakkimsetti
Copy link
Author

Touched the bundle now. Next build should be fine

@laeubi laeubi added this to the 3.0 milestone Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment