Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set-version: Fix regression overwriting mismatching versions #3836

Merged
merged 1 commit into from May 8, 2024

Conversation

sratz
Copy link
Contributor

@sratz sratz commented May 8, 2024

Fix regression introduced in #3343.

Also for the child modules the version of the change must match, so that it does not blindly overwrite the versions of the submodules.

Fixes #3808.

Fix regression introduced in eclipse-tycho#3343.

Also for the child modules the version of the change must match, so that
it does not blindly overwrite the versions of the submodules.

Fixes eclipse-tycho#3808.
Copy link

github-actions bot commented May 8, 2024

Test Results

  594 files    594 suites   3h 55m 21s ⏱️
  421 tests   413 ✅  7 💤 1 ❌
1 263 runs  1 239 ✅ 22 💤 2 ❌

For more details on these failures, see this check.

Results for commit ebcb491.

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label May 8, 2024
@laeubi laeubi merged commit 8cb0cc7 into eclipse-tycho:main May 8, 2024
9 of 12 checks passed
@eclipse-tycho-bot
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@sratz sratz deleted the set-version-fix branch May 8, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tycho-version-plugin] Since 4.0.5 non-matching version of child modules are forcefully overwritten
3 participants