Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to generate the top list of modules (based on a pattern) #3504

Open
vogella opened this issue Feb 13, 2024 · 1 comment
Open

Allow to generate the top list of modules (based on a pattern) #3504

vogella opened this issue Feb 13, 2024 · 1 comment

Comments

@vogella
Copy link
Contributor

vogella commented Feb 13, 2024

Tychos build extension allows to include modules based on common directories in

private static final Set<String> COMMON_NAMES = Set.of(System.getProperty(TYCHO_POMLESS_AGGREGATOR_NAMES_PROPERTY,

If we have a flat structure I still have to add the modules manually.

To simplify this, Tycho could allow to specify another directory in which another pom file is generated in which all modules are listed which belong to the main directory. This would allow to configure only one module in the parent pom and all other.

(Maybe this could also be combined with the build.properties settings to define directory patterns which should be include or not).

@laeubi
Copy link
Member

laeubi commented Feb 13, 2024

If we have a flat structure I still have to add the modules manually.

Tycho pomless works best with a structured layout ...

To simplify this, Tycho could allow to specify another directory in which another pom file is generated in which all modules are listed which belong to the main directory. This would allow to configure only one module in the parent pom and all other.

One could simply use a structured layout as well instead of adding some kind of indirection ... the main issue with such approaches is that they need to be smart for little benefit and heavily complicate things, e.g if it is a sub directory, it also needs to use a different parent in the flat modules (because the default for a parent is ../pom.xml), then in a flat hierarchy often people have also an extra parent so we need to account for this and so on...

So I would recommend to use a structured layout if you want to have it easy and convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants