Tycho P2 resolution fails with 2.5.0 #341
Comments
|
Can you give more context (e.g. link to the bundle source code that fails the resolution?) Tycho 2.5.0 has some improvements for complex setups, but maybe your case is not covered well, but maybe your bundle simply missing a requirement? |
|
A minimal reproducer for this issue would be helpful.
…--
Mickael Istria
Eclipse IDE <https://www.eclipse.org/eclipseide> developer, for Red Hat
Developers <https://developers.redhat.com/>
|
|
to reproduce, you can use the above repo ( jbosstools-livereload ) and just run mvn package on root. it will fails with the above error. the workaround is to use tycho 2.4 ( and use -DtychoVersion=2.4.0) to make it pass or remove the test bundle from reactor. It's a very simple example the consist of 2 bundles, core and UI, and a test. if I change the range to exclude 4.0, like jetty , it fails |
Can you please try to build a simpler example? Eg a single plugin module with just the necessary content in the MANIFEST.MF to make it fail + an appropriate .target file. |
|
my bad, you must use our specific settings to configure the repo where the parent/tp are located : |
|
Hi again. gist here : https://gist.github.com/sbouchet/3a3d8ca06d99d6fae009ba6cadaa10d2 |
|
Perfect, thanks! I'll look at it shortly. |
|
The gist shows this project is failing to build with 2.4.0 already. How does it highlight a 2.5.0 specific issue? |
? the first line is using Tycho 2.4.0 and ends as success. Then in the middle, there is the default mvn using Tycho 2.5.0 and fails. |
|
Sorry, my mistake. |
By the way this indicates that somewhere you are using an indirect import (e.g. javax.servlet is used but not imported) as it is a test-bundle that seems to cause the issue here, are you importing the package there? |
|
FWIW, I see a different issue locally, which doesn't happen with 2.4 but happens with 2.5 |
|
For the issue I face (see previous comment), this can be reproduced with a single module and MANIFEST.MF being Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-SymbolicName: org.jboss.tools.tycho_341.test;singleton:=true
Bundle-Version: 0.1.0.qualifier
Require-Bundle: org.eclipse.jetty.security;bundle-version="[9.4.0,9.5.0)",
org.eclipse.wst.server.preview;bundle-version="1.1.102"
Bundle-RequiredExecutionEnvironment: JavaSE-11The reason is that wst.server.preview does require Jetty 10 which this bundle requires Jetty 9.4.x. |
|
OK, i can try to update to jetty 10 on my side, and if not possible/too complex, try out your workaround. |
Hi, Also not related but removing jetty 9.x completly from our product is not possible, since EGit stills require it.. (see https://git.eclipse.org/c/egit/egit.git/tree/org.eclipse.egit.target/egit-4.21.target ) |
Platform does contain jetty 10: https://download.eclipse.org/eclipse/updates/4.21/R-4.21-202109060500/plugins/ , you should use this repo. |
yes, but it's not the whole jetty here, only the bundles needed by platform. our bundles extends websocket and it's not part of it. |
|
It's worth trying jetty/jetty.project#6403 . If this works for you and eclipse platform moves to use it too this might be the ultimate solution. |
Is |
|
This one seems to have stalled. Thus I'm closing. Please reopen if there is still issue for you and you're ready to help with figuring it out. |
Hi,
while moving our builds to tycho 2.5.0, one of them suddenly fails with an Unresolved Requirement error :
Unresolved requirement: Import-Package: javax.servlet; version="[3.1.0,4.0.0)"
I tried multiple changes locally but still have this error ( like directly use the javax.servlet bundle )
It was working on tycho 2.4.0. I'm not sure what changed in the resolver since 2.4, and why it's only failing on this build only.
here is the falling PR: jbosstools/jbosstools-livereload#147
and here is the working one: jbosstools/jbosstools-livereload#148
The text was updated successfully, but these errors were encountered: