Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tycho-compiler-plugin] sync with recent maven changes #3351

Open
laeubi opened this issue Jan 11, 2024 · 3 comments
Open

[tycho-compiler-plugin] sync with recent maven changes #3351

laeubi opened this issue Jan 11, 2024 · 3 comments

Comments

@laeubi
Copy link
Member

laeubi commented Jan 11, 2024

Currently Tycho has a copied version of AbstractCompilerMojo but this is very outdated.

We should

  1. Check what adjustments Tycho needs and probably bring them upstream
  2. Sync the code so we have at least comparable functions
@laeubi
Copy link
Member Author

laeubi commented Jan 11, 2024

One thing seems to be that

copied.org.apache.maven.plugin.AbstractCompilerMojo.getCompilerConfiguration(List<String>, List<String>)

is added to change/enhance the compiler config by extensing mojos ,that looks like something that could be applied upstream without much of a problem.

@laeubi
Copy link
Member Author

laeubi commented Jan 11, 2024

Another issue is that the default value for compilerId is different this is something that might be discussed with the maven-devs if there is an alternative in copy the whole class.

@laeubi
Copy link
Member Author

laeubi commented Jan 11, 2024

Another thing seems

compilerConfiguration.setSourceVersion(source != null ? source : DEFAULT_SOURCE_VERSION);
compilerConfiguration.setTargetVersion(target != null ? target : DEFAULT_TARGET_VERSION);
if (release != null) {
      compilerConfiguration.setReleaseVersion(release);
}

it would be good to have this as methods as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant