Target file resolve, How to force ignore artifacts from a specific site? #332

jcompagner · 2021-10-12T09:33:34Z

jcompagner
Oct 12, 2021

When i have this target file:

    <location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
	    <repository location="https://download.eclipse.org/eclipse/updates/4.21/"/>
	    <unit id="org.eclipse.equinox.executable.feature.group" version="3.8.1300.v20210828-0802"/>
	    <unit id="org.eclipse.sdk.ide" version="4.21.0.I20210906-0500"/>
    </location>
    <location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
	    <repository location="https://download.eclipse.org/releases/2021-09/"/>
        <unit id="org.eclipse.emf.sdk.feature.group" version="2.27.0.v20210816-1137"/>
        <unit id="org.eclipse.egit.feature.group" version="5.13.0.202109080827-r"/>
        <unit id="org.eclipse.jgit.feature.group" version="5.13.0.202109080827-r"/>
        <unit id="org.eclipse.jgit.http.apache.feature.group" version="5.13.0.202109080827-r"/>
        <unit id="org.eclipse.jgit.lfs.feature.group" version="5.13.0.202109080827-r"/>
	    <unit id="org.eclipse.jst.web_ui.feature.feature.group" version="3.23.0.v202107101916"/>
    </location>

and also besides that also our own p2 repo with some 3rd party plugins that are not shipped by eclipse/orbit

Then i now have a big problem because that aries.dynamic.bundle above has in the manifest imports like:

org.objectweb.asm;version="[9.1,10)",org.objectweb.asm.commons;version="[9.1,10)",org.objectweb.asm.util;version="[9.1,10)"

so it from 9.1 until 10.

but if you go to:

https://download.eclipse.org/releases/2021-09/202109151000/plugins/

you see that that update site also includes asm_9.2

which eclipse itself doesn't need or use:

https://download.eclipse.org/eclipse/updates/4.21/R-4.21-202109060500/plugins/

But i think because of that import tycho or p2 resolvement does try to match 9.2 that it finds in https://download.eclipse.org/releases/2021-09/

So i now get this error:

[ERROR] Internal error: java.lang.RuntimeException: org.osgi.framework.BundleException: Bundle sablo cannot be resolved:sablo [18]
[ERROR] Unresolved requirement: Require-Bundle: slf4j.api
[ERROR] -> Bundle-SymbolicName: slf4j.api; bundle-version="1.8.0.beta3-SNAPSHOT"
[ERROR] slf4j.api [3]
[ERROR] Unresolved requirement: Require-Capability: osgi.serviceloader; filter:="(osgi.serviceloader=org.slf4j.spi.SLF4JServiceProvider)"
[ERROR] -> Provide-Capability: osgi.serviceloader; osgi.serviceloader="org.slf4j.spi.SLF4JServiceProvider"
[ERROR] org.apache.logging.log4j.slf4j18-impl [11]
[ERROR] Unresolved requirement: Import-Package: org.slf4j.spi; version="[1.8.0,2.0.0)"
[ERROR] -> Export-Package: org.slf4j.spi; bundle-symbolic-name="slf4j.api"; bundle-version="1.8.0.beta3-SNAPSHOT"; version="1.8.0.beta3-SNAPSHOT"
[ERROR] Unresolved requirement: Require-Capability: osgi.extender; filter:="(osgi.extender=osgi.serviceloader.registrar)"
[ERROR] -> Provide-Capability: osgi.extender; osgi.extender="osgi.serviceloader.registrar"; version:Version="1.0.0"
[ERROR] org.apache.aries.spifly.dynamic.bundle [4]
[ERROR] Bundle was not resolved because of a uses constraint violation.
[ERROR] org.apache.felix.resolver.reason.ReasonException: Uses constraint violation. Unable to resolve resource org.apache.aries.spifly.dynamic.bundle [osgi.identity; osgi.identity="org.apache.aries.spifly.dynamic.bundle"; type="osgi.bundle"; version:Version="1.3.3"] because it is exposed to package 'org.objectweb.asm' from resources org.objectweb.asm [osgi.identity; osgi.identity="org.objectweb.asm"; type="osgi.bundle"; version:Version="9.2.0.v20210813-1119"] and org.objectweb.asm [osgi.identity; osgi.identity="org.objectweb.asm"; type="osgi.bundle"; version:Version="9.1.0.v20210209-1849"] via two dependency chains.
[ERROR]
[ERROR] Chain 1:
[ERROR] org.apache.aries.spifly.dynamic.bundle [osgi.identity; osgi.identity="org.apache.aries.spifly.dynamic.bundle"; type="osgi.bundle"; version:Version="1.3.3"]
[ERROR] import: (&(osgi.wiring.package=org.objectweb.asm)(&(version>=9.1.0)(!(version>=10.0.0))))
[ERROR] |
[ERROR] export: osgi.wiring.package: org.objectweb.asm
[ERROR] org.objectweb.asm [osgi.identity; osgi.identity="org.objectweb.asm"; type="osgi.bundle"; version:Version="9.2.0.v20210813-1119"]
[ERROR]
[ERROR] Chain 2:
[ERROR] org.apache.aries.spifly.dynamic.bundle [osgi.identity; osgi.identity="org.apache.aries.spifly.dynamic.bundle"; type="osgi.bundle"; version:Version="1.3.3"]
[ERROR] import: (&(osgi.wiring.package=org.objectweb.asm.commons)(&(version>=9.1.0)(!(version>=10.0.0))))
[ERROR] |
[ERROR] export: osgi.wiring.package=org.objectweb.asm.commons; uses:=org.objectweb.asm
[ERROR] org.objectweb.asm.commons [osgi.identity; osgi.identity="org.objectweb.asm.commons"; type="osgi.bundle"; version:Version="9.1.0.v20210209-1849"]
[ERROR] import: (&(osgi.wiring.package=org.objectweb.asm)(&(version>=9.1.0)(!(version>=9.2.0))))
[ERROR] |
[ERROR] export: osgi.wiring.package: org.objectweb.asm
[ERROR] org.objectweb.asm [osgi.identity; osgi.identity="org.objectweb.asm"; type="osgi.bundle"; version:Version="9.1.0.v20210209-1849"]
Unresolved requirement: Import-Package: org.slf4j; version="[1.8.0,2.0.0)"
[ERROR] -> Export-Package: org.slf4j; bundle-symbolic-name="slf4j.api"; bundle-version="1.8.0.beta3-SNAPSHOT"; version="1.8.0.beta3-SNAPSHOT"
[ERROR] Bundle was not resolved because of a uses constraint violation.
[ERROR] org.apache.felix.resolver.reason.ReasonException: Uses constraint violation. Unable to resolve resource org.apache.aries.spifly.dynamic.bundle [osgi.identity; osgi.identity="org.apache.aries.spifly.dynamic.bundle"; type="osgi.bundle"; version:Version="1.3.3"] because it is exposed to package 'org.objectweb.asm' from resources org.objectweb.asm [osgi.identity; osgi.identity="org.objectweb.asm"; type="osgi.bundle"; version:Version="9.2.0.v20210813-1119"] and org.objectweb.asm [osgi.identity; osgi.identity="org.objectweb.asm"; type="osgi.bundle"; version:Version="9.1.0.v20210209-1849"] via two dependency chains.

because i think it finds 2 of them..

But it shouldn;t do that, i haven't selected those plugins, only some other features from https://download.eclipse.org/releases/2021-09/ like EGit.

How can i stil use the above urls and target file and force tycho/p2 to not use 9.2 for this but keep what the main Eclipse SDK just wants to use (9.1)?

I dont think this is fully tycho because also if i do an "export" from the target file editor and i see what it generates in the above scenario it also has both of those jar versions.

the only way that i can fix this at this moment is not to use:

    <location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
	    <repository location="https://download.eclipse.org/releases/2021-09/"/>
        <unit id="org.eclipse.emf.sdk.feature.group" version="2.27.0.v20210816-1137"/>
        <unit id="org.eclipse.egit.feature.group" version="5.13.0.202109080827-r"/>
        <unit id="org.eclipse.jgit.feature.group" version="5.13.0.202109080827-r"/>
        <unit id="org.eclipse.jgit.http.apache.feature.group" version="5.13.0.202109080827-r"/>
        <unit id="org.eclipse.jgit.lfs.feature.group" version="5.13.0.202109080827-r"/>
	    <unit id="org.eclipse.jst.web_ui.feature.feature.group" version="3.23.0.v202107101916"/>
    </location>

but for all 3 features i import there use there own repo:

<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
        <repository location="https://download.eclipse.org/modeling/emf/emf/builds/release/2.27/"/>
        <unit id="org.eclipse.emf.sdk.feature.group" version="2.27.0.v20210816-1137"/>
    </location>
    <location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
        <repository location="https://download.eclipse.org/egit/updates-5.13/"/>
        <unit id="org.eclipse.egit.feature.group" version="5.13.0.202109080827-r"/>
        <unit id="org.eclipse.jgit.feature.group" version="5.13.0.202109080827-r"/>
        <unit id="org.eclipse.jgit.http.apache.feature.group" version="5.13.0.202109080827-r"/>
        <unit id="org.eclipse.jgit.lfs.feature.group" version="5.13.0.202109080827-r"/>
    </location>
    <location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
        <repository location="https://download.eclipse.org/webtools/downloads/drops/R3.23.0/R-3.23.0-20210822084517/repository/"/>
        <unit id="org.eclipse.jst.web_ui.feature.feature.group" version="3.23.0.v202107101916"/>
    </location>

if i do that, then it seems to be working again, the above error doesn't happen.
and also the target site that is created by using the export feature of the target file editor is also fine.

But that is a bit annoying that i now need to use 3 specific update sites instead of just 1

does a target file has an option to force exclude stuff?

Answered by jcompagner

Oct 12, 2021

ok after a lot of testing i finally did see that 1 pom file was still on tycho 2.3 ...
And changing that fixed at least the build problem, so tycho wise it can handle this now.

But i can't still use the target like that, because the product build that i do is just in my eyes not ok:

all kinds of duplicates, no idea which one really comes up and does what..

if i use the target file that doesn't use the https://download.eclipse.org/releases/2021-09/ as a whole but takes the 3 things i get from there from there own sites, the generated product is nice

no doubles anymore, (asm itself and tree) and even utils is now just 9.1 and not only 9.2 (i wonder how that would match up at runtime)

View full answer

laeubi · 2021-10-12T09:41:45Z

laeubi
Oct 12, 2021
Maintainer

You can configure exclusion filters, beside that Tycho 2.5.x has a possible fix for this kind of resolution errors.

4 replies

jcompagner Oct 12, 2021
Author

i am using Tycho 2.5 for this already.
will try to exclusion filters, but it seems to me that P2 is more the problem (it also generates a p2 site where the wrong version jars are also added). I created also a case for that: https://bugs.eclipse.org/bugs/show_bug.cgi?id=576570

because to me it sounds that you really want this exclusion list inside the xx.target file..

jcompagner Oct 12, 2021
Author

now i think about this, i have to set this exclusion list over all the pom files that are using the my target file as the source..
Which is quite a few, and when eclipse moves itself to asm9.2 then i have to not forget to adjust all that again..

laeubi Oct 12, 2021
Maintainer

That's strange, the use-constraint violations should not happen anymore with tycho 2.5.0 do you think you can derive a test-case from this?
We already have https://github.com/eclipse/tycho/tree/master/tycho-its/projects/resolver.usesConstraintViolations but this test passes so it would be interesting to find out what is different in your case. Target exclusions are currently not supported by tycho (and PDE has implemented it rather strange as a white-list instead of a black-list...)

jcompagner Oct 12, 2021
Author

let me try to make a copy of that and see if i can make it break

laeubi · 2021-10-12T09:58:20Z

laeubi
Oct 12, 2021
Maintainer

Then i now have a big problem because that aries.dynamic.bundle above has in the manifest imports like:

Just a note on this: Aries behaves correct here and having version ranges on package imports is actually a good thing...

1 reply

jcompagner Oct 12, 2021
Author

yes i know, i think if they would do: org.objectweb.asm;version="[9.1,9.2)",
i wouldn't have my problem, but i guess they assume that this version should work for all minor releases, so i get why the have ,10)

jcompagner · 2021-10-12T14:14:51Z

jcompagner
Oct 12, 2021
Author

ok after a lot of testing i finally did see that 1 pom file was still on tycho 2.3 ...
And changing that fixed at least the build problem, so tycho wise it can handle this now.

But i can't still use the target like that, because the product build that i do is just in my eyes not ok:

all kinds of duplicates, no idea which one really comes up and does what..

if i use the target file that doesn't use the https://download.eclipse.org/releases/2021-09/ as a whole but takes the 3 things i get from there from there own sites, the generated product is nice

no doubles anymore, (asm itself and tree) and even utils is now just 9.1 and not only 9.2 (i wonder how that would match up at runtime)

0 replies

akurtakov · 2021-10-12T14:33:27Z

akurtakov
Oct 12, 2021
Maintainer

I have a feeling that smth included in your product in 2021-09 have a requirement [9.2.0,..) which forces p2 to put both. Please check what else in your product requires asm and what are the version ranges.

21 replies

jcompagner Oct 13, 2021
Author

you require org.eclipse.osgi what almost always is problematic as this is the system bundle so your are have a hard requirement to the equinox framework and wire almost everything it exports to your bundle, better import the OSGi packages with consumer version range

same for org.apache.commons.io (I assume you won't need everything from it nor does it contains any split-packages)

thx, yes i was planning to move stuff more from bundle imports to package imports (its already ungoing)
but yeah X number of years ago it you would normally do the bundle import so that stays a bit.
But i know its better now to just do package imports (with a version range)

i did find that the hard way also in some bundles because there are currently bundles that have a different bundle name but they export the same packages.. (as an example every webcontainer (like tomcat) has there own javax.servlet bundle with ofcourse the same packages but they all name it differently)

You export com.servoy.eclipse.ngclient.ui but without declaring use-contraints on javax.servlet.* but seem to use it there, so you should let PDE calculate uses attributes to make sure the OSGi resolver only wires importers of com.servoy.eclipse.ngclient.ui to the same javax.servlet packages. The same applies to your package exports of the Tomcat bundle.

thx, will have a look for this.

Beside that, you might want to take a look at pax-web what implements the Web Applications Specification and Http Whiteboard Specification that is allows OSGi compatible web technologies without eclipse specific extension points (that are not dynamic aware enough in most cases).

our product is purely an eclipse product and we are in full control about that, so i don't care to much about that we use the eclipse extension point for this. Its not that that will be used in another setting.
But if the above is fixing also the case that we solve with the extension point that we want to contribute @webfilter or @WebServlet that is in developer just in other plugins, so not something tomcat will find in its context (so the tomcat scanner will find them), then i will have a look.
Because that is currently the only thing we solve, our product can also do an export (that generates a WAR) that then has all the Filters/Servlets in the WAR/WEB-INF/xxx so tomcat will find them. But when starting in our IDE, tomcat also needs them (or in some cases a special version of the filter that understands that it runs in an eclipse product (can access the workspace and so on)), so in this scenario we just give them programmatically and add them to the (root) tomcat context programmatically.

laeubi Oct 13, 2021
Maintainer

With WABs (Web application bundles) you can also deploy "war-style" code but I have never used that...

jcompagner Oct 13, 2021
Author

i have to say the not so nice thing about package imports is this scenario:

public class CopySourceFolderAction extends Action

that Action is org.eclipse.jface.action

so if i removed the jface bundle then i get a compile error
i can fix that by having a quick fix on Action and import then that package (org.eclipse.jface.action)
But that doesn't fix the full problem because then you get:

"The hierarchy of the type CopySourceFolderAction is inconsistent"

which is not that easy to fix, you really need to go over the hierarchy and guess what you need to import by looking at interfaces or the extends classes..... (and happily we have the source....)

so it is not so nice that i also need to import the package: org.eclipse.core.commands.common
because Action extends AbstractAction which extends org.eclipse.core.commands.common.EventManager

jcompagner Oct 13, 2021
Author

ha ;)
https://bugs.eclipse.org/bugs/show_bug.cgi?id=571338#c3

I am not the only one that is complaining about that :)

laeubi Oct 13, 2021
Maintainer

you - are - not- ALOOONNNNEEE ;-)

jface is probably a good candidate for require-bundle as most eclipse-ui bundles :-\

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Target file resolve, How to force ignore artifacts from a specific site? #332

{{title}}

Replies: 4 comments 26 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Target file resolve, How to force ignore artifacts from a specific site? #332

jcompagner Oct 12, 2021

Replies: 4 comments · 26 replies

laeubi Oct 12, 2021 Maintainer

jcompagner Oct 12, 2021 Author

jcompagner Oct 12, 2021 Author

laeubi Oct 12, 2021 Maintainer

jcompagner Oct 12, 2021 Author

laeubi Oct 12, 2021 Maintainer

jcompagner Oct 12, 2021 Author

jcompagner Oct 12, 2021 Author

akurtakov Oct 12, 2021 Maintainer

jcompagner Oct 13, 2021 Author

laeubi Oct 13, 2021 Maintainer

jcompagner Oct 13, 2021 Author

jcompagner Oct 13, 2021 Author

laeubi Oct 13, 2021 Maintainer

jcompagner
Oct 12, 2021

Replies: 4 comments 26 replies

laeubi
Oct 12, 2021
Maintainer

jcompagner Oct 12, 2021
Author

jcompagner Oct 12, 2021
Author

laeubi Oct 12, 2021
Maintainer

jcompagner Oct 12, 2021
Author

laeubi
Oct 12, 2021
Maintainer

jcompagner Oct 12, 2021
Author

jcompagner
Oct 12, 2021
Author

akurtakov
Oct 12, 2021
Maintainer

jcompagner Oct 13, 2021
Author

laeubi Oct 13, 2021
Maintainer

jcompagner Oct 13, 2021
Author

jcompagner Oct 13, 2021
Author

laeubi Oct 13, 2021
Maintainer