Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some files can not be saved when losing and restoring network connection #13702

Closed
zhuanshenlikai opened this issue May 9, 2024 · 2 comments
Closed

Comments

@zhuanshenlikai
Copy link

Bug Description:
In the recent version of Theia, a frontendConnectionTimeout parameter has been provided in the backend socket keep-alive mechanism. This parameter is used to set the timeout period for the backend socket to wait for a connection after the frontend socket is disconnected. I have set this timeout period to 5 seconds.When the network connection was interrupted, I started editing a file. When the network was restored, I found that I was unable to close and save that file.

Steps to Reproduce:
1.Opened a file called demo.js.
2.Disconnected the network and made some changes to demo.js. At this point, the file couldn't be saved because the network was disconnected, which is expected.
3.Reconnected the network and noticed that the unsaved changes in demo.js couldn't be saved anymore.

After multiple attempts, it seems that this is because the time taken to reconnect after the network was disconnected was less than 5 seconds. As a result, the backend continued to reuse the old socket, which caused the inability to save the file.

Additional Information:

  • Operating System: debian docker
  • Theia Version: 1.47.1
@zhuanshenlikai zhuanshenlikai changed the title Some files can not be saved Some files can not be saved when losing and restoring network connection May 9, 2024
@zhuanshenlikai
Copy link
Author

@msujew Could you help to resolve it,thank you.

@msujew
Copy link
Member

msujew commented May 15, 2024

I actually just noticed that the issue is a duplicate of #12195. Please continue the discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants