Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabGroup.viewColumn and Editor.viewColumn are out of sync for the same editor. #13679

Open
tsmaeder opened this issue May 3, 2024 · 1 comment
Labels
vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented May 3, 2024

Bug Description:

When starting up typescript-language-features 1.881 the context key typescript.isManagedFile is never set. Analyzing the problem led to finding out that the extension fails to find the active typescritpt editor due to this comparison failing for the single open editor:

editor.viewColumn === tab.group.viewColumn;

editor.viewColumn is one and tab.group.ViewColumn is 2, but there is only one editor open.

Steps to Reproduce:

n/a

Additional Information

  • Operating System: Windows 11
  • Theia Version: Theia 1.49 master
tsmaeder added a commit to tsmaeder/theia that referenced this issue May 3, 2024
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder
Copy link
Contributor Author

tsmaeder commented May 5, 2024

Remove the workaround from #13673 once we have a fix here.

@tsmaeder tsmaeder added the vscode issues related to VSCode compatibility label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

1 participant