-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overflow behavior for sidepanels not working correctly #13482
Comments
tortmayr
added a commit
to eclipsesource/theia
that referenced
this issue
Mar 12, 2024
- Ensure that last visible element also gets added to `...` overflow menu if there is not enough space - Remove special behavior for only one overflowing element - This behavior would always add a second element to the `overflow` menu if only one element is currently overflowing. This did not work for the case where only two tabs where open in the first place. In addition, it unnecessarily hide a tab in some cases even if there was enough space to render it. - Also consider potential tab margins in overflow computation Fixes eclipse-theia#13482 Contributed on behalf of STMicroelectronics
1 task
I don't really understand what the problem here is. For me, this seems to work just fine: any view that is hidden is added to the |
@tortmayr ping. |
tortmayr
added a commit
to eclipsesource/theia
that referenced
this issue
Mar 26, 2024
- Ensure that last visible element also gets added to `...` overflow menu if there is not enough space - Remove special behavior for only one overflowing element - This behavior would always add a second element to the `overflow` menu if only one element is currently overflowing. This did not work for the case where only two tabs where open in the first place. In addition, it unnecessarily hide a tab in some cases even if there was enough space to render it. - Also consider potential tab margins in overflow computation Fixes eclipse-theia#13482 Contributed on behalf of STMicroelectronics
tortmayr
added a commit
to eclipsesource/theia
that referenced
this issue
May 10, 2024
- Ensure that last visible element also gets added to `...` overflow menu if there is not enough space - Remove special behavior for only one overflowing element - This behavior would always add a second element to the `overflow` menu if only one element is currently overflowing. This did not work for the case where only two tabs where open in the first place. In addition, it unnecessarily hide a tab in some cases even if there was enough space to render it. - Also consider potential tab margins in overflow computation Fixes eclipse-theia#13482 Contributed on behalf of STMicroelectronics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description:
For certain corner cases the tab overflow behavior for sidebars introduced with #12593 is not working correctly:
...
menu even if there is not enough space to show it.Overflow computation does not consider potential custom styling. Eg. if additional margin between icons are added in an adopter project the overflow calculation will be off.
The text was updated successfully, but these errors were encountered: