Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The key binding shown hides cursor #48

Open
frankbenoit opened this issue May 1, 2022 · 6 comments · May be fixed by #1592
Open

The key binding shown hides cursor #48

frankbenoit opened this issue May 1, 2022 · 6 comments · May be fixed by #1592

Comments

@frankbenoit
Copy link

frankbenoit commented May 1, 2022 •
edited

There are those settings in Preferences -> keys to show the key binding when command is invoked, by mouse and/or keyboard.
I find this very helpful when programming with shared screen.

However, when the cursor is at the end of the file, each keystroke (e.g. Ctrl Arrow left/right) brings up the window and it hides the cursor position. That is very annoying.
At would be helpful if that window is direct to another location when the focus is in text editor and the cursor at the bottom.
@mickaelistria
Copy link
Contributor

Would you be interested in submitting a patch that fixes it? The relevant piece of code would be https://github.com/eclipse-platform/eclipse.platform.ui/blob/master/bundles/org.eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/internal/keys/show/ShowKeysUI.java

@mickaelistria mickaelistria transferred this issue from eclipse-platform/eclipse.platform May 2, 2022
@elsazac
Copy link
Member

elsazac commented Jan 30, 2024

I had a look at this. getShell().getCaret() is giving me null and because of that I am unable to detect the overlap. Any suggestions ?

@BeckerWdf
Copy link
Contributor

I think it would feel strange when the window showing the shortcut opens at different locations.

The window showing the shortcut has some transparency to mitigate the issue that it could overlap with some important part of the workbench. Maybe we could increase the transparency a bit more.

@elsazac
Copy link
Member

elsazac commented Jan 30, 2024

I think it would feel strange when the window showing the shortcut opens at different locations.

The window showing the shortcut has some transparency to mitigate the issue that it could overlap with some important part of the workbench. Maybe we could increase the transparency a bit more.

@BeckerWdf Thanks for the suggestion. This looks reasonable to me.

@frankbenoit Are you ok with this approach? Let me know. If yes I will investigate on this.

@elsazac elsazac linked a pull request Jan 30, 2024 that will close this issue
Open
@BeckerWdf
Copy link
Contributor

@frankbenoit: Are you ok with the proposed change?

@frankbenoit
Copy link
Author

Yes, if the editors writing/cursor is good readable this is fine.

@WJSchakel WJSchakel mentioned this issue Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

increase transparency of showKeyPopUp elsazac/eclipse.platform.ui
4 participants
@mickaelistria @frankbenoit @BeckerWdf @elsazac