Avoid segfaults in j9vmem_testOverlappingSegments #19517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the keepCycles array is zero-initialized, if the test is aborted in the very first cycle (i == 0) the cleanup procedure at the end cannot rely on the fact that keepCycles[j] >= i implies that segment j must be freed. Before these changes, such a scenario would cause the test to segfault during cleanup. Signed-off-by: Christian Despres <despresc@ibm.com>
cjjdespres
force-pushed
the
fix-overlapping-segment-test
branch
from
9d8a2f6
to
a464dc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
keepCyclesarray is zero-initialized, if the test is aborted in the very first cycle (i == 0) the cleanup procedure at the end cannot rely on the fact thatkeepCycles[j] >= iimplies that segmentjmust be freed. Before these changes, such a scenario would cause the test to segfault during cleanup.Fixes: #19509