Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpringBootGeneratorIntegrationTest : Replace AssertJ's deprecated asList() DSL method with asInstanceOf(InstanceOfAssertFactories.list(type.class)) #3058

Closed
1 task
rohanKanojia opened this issue May 15, 2024 · 3 comments · Fixed by #3075
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@rohanKanojia
Copy link
Member

Component

JKube Kit

Task description

Description

In the latest versions of Assertj asList() DSL method has been marked as deprecated:

.asList().hasSize(1)
.satisfies(layers -> assertThat(layers).element(0).asInstanceOf(InstanceOfAssertFactories.type(Assembly.class))
.extracting(Assembly::getFileSets)
.asList().element(2)
.hasFieldOrPropertyWithValue("outputDirectory", new File("."))
.extracting("includes").asList()

users are advised to use asInstanceOf(InstanceOfAssertFactories.list(type.class)) instead, we need to update asList() calls with this.

Expected Behavior

AssertJ's asList() is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class))

Acceptance Criteria

  • asList() DSL method call is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class)) in all places
@rohanKanojia rohanKanojia added good first issue Good for newcomers help wanted Extra attention is needed labels May 15, 2024
@Josephvictor
Copy link
Contributor

Can I work on this?

@rohanKanojia
Copy link
Member Author

@Josephvictor Hello, help wanted issues are created for contributors who have already contributed to the project. I can see that you haven’t contributed to the project before.

Even if you are quite skilled, please consider doing one little (first-timers-only ) issue to get used to the process. After that, you are invited to move on up to the more difficult tasks, leaving some of the easy tasks to others so they can get involved and achieve change themselves.

Maybe you should start with issues created for first timers first-timers-only

@arman-yekkehkhani
Copy link
Contributor

@rohanKanojia Hello, could you assign it to me?

arman-yekkehkhani added a commit to arman-yekkehkhani/jkube that referenced this issue May 19, 2024
… method asList(), issue eclipse-jkube#3058

Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
@manusa manusa added this to the 1.17.0 milestone May 20, 2024 — with automated-tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
4 participants