Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResourceUtilTest : Replace AssertJ's deprecated asList() DSL method with asInstanceOf(InstanceOfAssertFactories.list(type.class)) #3057

Closed
1 task
rohanKanojia opened this issue May 15, 2024 · 1 comment · Fixed by #3073
Closed
1 task

ResourceUtilTest : Replace AssertJ's deprecated asList() DSL method with asInstanceOf(InstanceOfAssertFactories.list(type.class)) #3057

rohanKanojia opened this issue May 15, 2024 · 1 comment · Fixed by #3073
Assignees
@arman-yekkehkhani
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone
1.17.0

Comments

@rohanKanojia
Copy link
Member

Component

JKube Kit

Task description

Description

In the latest versions of Assertj asList() DSL method has been marked as deprecated:

jkube/jkube-kit/common/src/test/java/org/eclipse/jkube/kit/common/util/ResourceUtilTest.java

Lines 112 to 113 in bfbf08d

.extracting("spec.containers").asList().first()
.extracting("env").asList()

users are advised to use asInstanceOf(InstanceOfAssertFactories.list(type.class)) instead, we need to update asList() calls with this.

Expected Behavior

AssertJ's asList() is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class))

Acceptance Criteria

  • asList() DSL method call is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class)) in all places
@rohanKanojia rohanKanojia added good first issue Good for newcomers help wanted Extra attention is needed labels May 15, 2024
@arman-yekkehkhani
Copy link
Contributor

@rohanKanojia Hi! Can I work on this?

arman-yekkehkhani added a commit to arman-yekkehkhani/jkube that referenced this issue May 17, 2024
@arman-yekkehkhani
fix(ResourceUtilTest): replace AssertJ's deprecated method asList(), …
5f44687 
…issue eclipse-jkube#3057

Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
@arman-yekkehkhani arman-yekkehkhani mentioned this issue May 17, 2024
Merged
17 tasks
arman-yekkehkhani added a commit to arman-yekkehkhani/jkube that referenced this issue May 22, 2024
@arman-yekkehkhani
fix(ResourceUtilTest): avoid wildcard imports, issue eclipse-jkube#3057
e230dbe 
Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
@manusa manusa added this to the 1.17.0 milestone May 22, 2024 — with automated-tasks
manusa pushed a commit that referenced this issue May 22, 2024
@arman-yekkehkhani
fix: replace AssertJ's deprecated asList() DSL method in ResourceUtil…
1f32ccd 
…Test (3073)

fix(ResourceUtilTest): replace AssertJ's deprecated method asList(), issue #3057

Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
---
fix(ResourceUtilTest): avoid wildcard imports, issue #3057

Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arman-yekkehkhani arman-yekkehkhani

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
1.17.0
Development

Successfully merging a pull request may close this issue.

fix ResourceUtilTest: replace AssertJ's deprecated method asList() arman-yekkehkhani/jkube
3 participants
@manusa @rohanKanojia @arman-yekkehkhani