Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubernetesWatchTask.getWatchContext The declared Exception exception is never thrown #3054

Closed
1 task done
manusa opened this issue May 15, 2024 · 1 comment · Fixed by #3086
Closed
1 task done
Assignees
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Milestone

Comments

@manusa
Copy link
Member

manusa commented May 15, 2024

Description

The method KubernetesWatchTask.getWatchContext declares an Exception that is never thrown.

The following line

  • should be changed to:
  private WatchContext getWatchContext() {

Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇👇👇👇👇👇👇
Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

@manusa manusa added good first issue Good for newcomers first-timers-only Is this your first time contributing? This could be a good place to start! labels May 15, 2024
@kiratkumar47
Copy link
Contributor

Could you please assign this to me

kiratkumar47 pushed a commit to kiratkumar47/jkube that referenced this issue May 20, 2024
kiratkumar47 added a commit to kiratkumar47/jkube that referenced this issue May 20, 2024
@manusa manusa added this to the 1.17.0 milestone May 23, 2024 — with automated-tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Projects
None yet
2 participants