-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix assertion to check for non-zero status code in ExternalCommandTest #3070
Fix assertion to check for non-zero status code in ExternalCommandTest #3070
Conversation
…ode, issue eclipse-jkube#3006 Signed-off-by: arman-yekkehkhani <arman.yekkehkhani@gmail.com>
Eclipse JKube CI ReportStarted new GH workflow run for #3070 (2024-05-17T13:09:13Z) ⚙️ JKube E2E Tests (9124594932)
|
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3070 +/- ##
=============================================
+ Coverage 59.36% 71.01% +11.64%
- Complexity 4586 5069 +483
=============================================
Files 500 488 -12
Lines 21211 19445 -1766
Branches 2830 2502 -328
=============================================
+ Hits 12591 13808 +1217
+ Misses 7370 4419 -2951
+ Partials 1250 1218 -32 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Description
Command
ls
may finish with different exit codes on different operating systems. Modified the test caseexecute_whenCommandFailed_thenThrowException
to assert the non-zero exit code.Fixes #3006
Type of change
test, version modification, documentation, etc.)
Checklist