-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove getter methods and use lombok @Getter in HelmConfig.HelmType #3071
Conversation
Signed-off-by: Rohit Satya <work.rohitsatya@gmail.com>
Eclipse JKube CI ReportStarted new GH workflow run for #3071 (2024-05-17T10:45:03Z) ⚙️ JKube E2E Tests (9126835602)
|
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3071 +/- ##
=============================================
+ Coverage 59.36% 70.99% +11.63%
- Complexity 4586 5069 +483
=============================================
Files 500 488 -12
Lines 21211 19433 -1778
Branches 2830 2501 -329
=============================================
+ Hits 12591 13797 +1206
+ Misses 7370 4419 -2951
+ Partials 1250 1217 -33 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
@rohit-satya : This issue is already assigned to someone else. Please ask on the issue first whether the assignee is still working on it before directly creating pull request. |
@rohanKanojia I noticed that the issue has been assigned for a month now and I understand that this issue is a simple one. Going forward, I will keep in mind and raise a PR post the issue being assigned to me |
Please, add a comment on the issue so that we can reassign. |
Description
Remove getter methods and use Lombok
@Getter
annotation in HelmConfig.HelmTypeFixes #2930
Type of change
test, version modification, documentation, etc.)
Checklist