Revalidate open files in project when classpath updates. #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
rgrunber
reviewed
Jun 3, 2024
...clipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/ClasspathUpdateHandler.java
Outdated
Show resolved
Hide resolved
ethan-vanderheijden
force-pushed
the
revalidate-on-classpath-update
branch
from
c479ccb
to
59f726f
Compare
rgrunber
reviewed
Jun 6, 2024
There was a problem hiding this comment.
Change works well for me. I even tried with java.edit.validateAllOpenBuffersOnChanges on/off. They control different strategies of surfacing errors (one is through getting the working copies, the other is through client-side hooks).
I think this looks good to merge. Just one minor thing to remove.
...clipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/ClasspathUpdateHandler.java
Outdated
Show resolved
Hide resolved
ethan-vanderheijden
force-pushed
the
revalidate-on-classpath-update
branch
from
59f726f
to
a9fa8d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3155
It now re-validates all open files in a project when the project's classpath is updated. This only happens when autobuild is turned off (I assume that when autobuild is on, projects are automatically rebuilt when the classpath changes and files are re-validated in the process).
I implemented this through
ClasspathUpdateHandlerandDiagnosticsHandlerwhich is probably not a good idea (e.g. does this code belong inClasspathUpdateHandler? should we re-validate files throughDocumentLifeCycleHandlerto take advantage of debouncing?). Let me know if I should do anything differently.