Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: move methods rely on instantiation and invocation of protected inner classes #1303

Closed
DongChunHao opened this issue Apr 2, 2024 · 2 comments
Closed

Bug: move methods rely on instantiation and invocation of protected inner classes #1303

DongChunHao opened this issue Apr 2, 2024 · 2 comments
Assignees
@jjohnstn
Labels
bug Something isn't working

Comments

@DongChunHao
Copy link
Contributor

Move myMethod() to TargetClass

image

Refactoring results:

image
@jjohnstn jjohnstn self-assigned this May 17, 2024
@jjohnstn jjohnstn added the bug Something isn't working label May 17, 2024
jjohnstn added a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue May 17, 2024
@jjohnstn
Add new tests to MoveInstanceMethodTests
6134210 
- verifies eclipse-jdt#1303 is fixed
@jjohnstn
Copy link
Contributor

This is fixed by #1412. I have added new tests.

jjohnstn added a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue Jun 5, 2024
@jjohnstn
Add new tests to MoveInstanceMethodTests
43e1b39 
- verifies eclipse-jdt#1303 is fixed
jjohnstn added a commit that referenced this issue Jun 5, 2024
@jjohnstn
Fix move instance method when inner class is referenced (#1412)
878b93b 
* Fix move instance method when inner class is referenced

- fix MoveInstanceMethodProcessor to handle the cases where the
  method to move references a member class
- add new tests to MoveInstanceMethodTests
- fixes #1301
- verifies #1303 is fixed
@jjohnstn
Copy link
Contributor

jjohnstn commented Jun 5, 2024

Closing as fixed by #1412

@jjohnstn jjohnstn closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjohnstn jjohnstn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jjohnstn @DongChunHao